Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cache in term info and classroom #174

Closed
wants to merge 4 commits into from

Conversation

penqee
Copy link
Contributor

@penqee penqee commented Feb 8, 2025

自查 PR 结构

  • PR 标题符合这个格式: <type>(optional scope): <description>

  • 此 PR 标题的描述以用户为导向,足够清晰,其他人可以理解。

  • 我已经对所有 commit 提供了签名(GPG 密钥签名、SSH 密钥签名)

  • 这个 PR 属于强制变更/破坏性更改

如果是,请在 PR 标题中添加 BREAKING CHANGE 前缀,并在 PR 描述中详细说明。

这个 PR 的类型是什么?

这个 PR 做了什么 / 我们为什么需要这个 PR?

(可选)这个 PR 解决了哪个/些 issue?

添加缓存:

  1. 学期信息(已完成)
  2. 考场(已完成)

对 Reviewer 预留的一些提醒

@penqee penqee requested review from mutezebra, ozline, jiuxia211 and a team as code owners February 8, 2025 12:00
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 36.00000% with 32 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/cache/common/get_term_info.go 0.00% 11 Missing ⚠️
pkg/cache/common/set_term_info.go 0.00% 10 Missing ⚠️
internal/common/handler.go 0.00% 5 Missing ⚠️
pkg/cache/common/common.go 0.00% 2 Missing ⚠️
pkg/cache/common/util.go 0.00% 2 Missing ⚠️
cmd/common/main.go 0.00% 1 Missing ⚠️
pkg/cache/cache.go 0.00% 1 Missing ⚠️
@@           Coverage Diff            @@
##            main    #174      +/-   ##
========================================
+ Coverage   3.17%   3.27%   +0.09%     
========================================
  Files        200     204       +4     
  Lines      41114   41277     +163     
========================================
+ Hits        1306    1351      +45     
- Misses     39736   39848     +112     
- Partials      72      78       +6     
Flag Coverage Δ
unittest 3.27% <36.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/common/service/service.go 100.00% <100.00%> (ø)
internal/common/service/term.go 100.00% <100.00%> (ø)
cmd/common/main.go 0.00% <0.00%> (ø)
pkg/cache/cache.go 0.00% <0.00%> (ø)
pkg/cache/common/common.go 0.00% <0.00%> (ø)
pkg/cache/common/util.go 0.00% <0.00%> (ø)
internal/common/handler.go 0.00% <0.00%> (ø)
pkg/cache/common/set_term_info.go 0.00% <0.00%> (ø)
pkg/cache/common/get_term_info.go 0.00% <0.00%> (ø)

... and 30 files with indirect coverage changes

@penqee penqee requested a review from SchwarzSail as a code owner February 10, 2025 04:36
@penqee penqee changed the title [WIP] feat: add cache in term info and classroom feat: add cache in term info and classroom Feb 10, 2025
@penqee
Copy link
Contributor Author

penqee commented Feb 10, 2025

unit test时不时会failed

@mutezebra
Copy link
Member

unit test时不时会failed

这沟槽的 unit test, 到底是底层的问题还是包的问题

@penqee penqee closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants