Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency:Use logrus instead of zap #26

Closed
wants to merge 3 commits into from
Closed

Dependency:Use logrus instead of zap #26

wants to merge 3 commits into from

Conversation

mutezebra
Copy link
Member

使用logrus替代zap,维护依赖的统一性
依赖关系

@mutezebra
Copy link
Member Author

Refs #19

@ozline
Copy link
Member

ozline commented Oct 14, 2024

为什么要用 logrus 替代 zap?有分析吗?

@mutezebra
Copy link
Member Author

为什么要用 logrus 替代 zap?有分析吗?

之前logrus用的比较多没用过zap,然后发现logrus在这个项目里引用相对较多,就想着用logrus了
刚刚跑了一下benchmark才发现logrus性能上有点差强人意。
我稍后会关闭这个PR,然后基于zap替换logrus再提交

@mutezebra mutezebra closed this by deleting the head repository Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants