Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libspdm: bump to 3.5.0 release #118

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Conversation

twilfredo
Copy link
Contributor

Note that spdm-utils doesn't yet support the optional[1] SPDM 1.3 LIBSPDM_ENABLE_CAPABILITY_GET_KEY_PAIR_INFO_CAP and LIBSPDM_ENABLE_CAPABILITY_SET_KEY_PAIR_INFO_CAP=0 capabilities. So keep them disabled for now to avoid link errors.

[1] SPDM 1.3 Spec: Margin 184: https://www.dmtf.org/sites/default/files/standards/documents/DSP0274_1.3.0.pdf

Signed-off-by: Wilfred Mallawa <[email protected]>
@twilfredo twilfredo requested a review from alistair23 October 30, 2024 02:02
Update the CI workflow `libspdm` build parameters for compatibility with
`libspdm` version 3.5.0.

Signed-off-by: Wilfred Mallawa <[email protected]>
@twilfredo
Copy link
Contributor Author

This should go in after: #118

@twilfredo
Copy link
Contributor Author

@alistair23 ping

Instead of panicking at built time, just warn about the cbor tools not
being found. At run-time, `spdm-utils` will return an error when
attempting decode a cbor encoded manifest from a responder.

This should not affect a responder as we already have pre-generated
manifests checked in the `manifests/` directory.

Signed-off-by: Wilfred Mallawa <[email protected]>
@alistair23 alistair23 merged commit 1bf3c1b into master Nov 8, 2024
2 checks passed
@alistair23 alistair23 deleted the wilfred/bump-libspdm-3.5.0 branch November 8, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants