Support DeviceCert model as well as the AliasCert model #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The slot_id{} check is outdated, we don't seem to ever create the file
so let's remove it.
Signed-off-by: Alistair Francis <[email protected]>
Move the current certificates under the alias directory and also support device certificates. Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
alistair23
force-pushed
the
alistair/cert-model
branch
2 times, most recently
from
6978819 to
e6bc4f0
Compare
Signed-off-by: Alistair Francis <[email protected]>
alistair23
force-pushed
the
alistair/cert-model
branch
from
e6bc4f0 to
b008282
Compare
twilfredo
reviewed
Jul 15, 2024
| } else if certificate_model == "device" { | ||
| CertModel::Device | ||
| } else { | ||
| panic!("Unsupported certificate model"); |
There was a problem hiding this comment.
the else can be removed, since certificate_model default to "alias". That part should be unreachable.
There was a problem hiding this comment.
We need the else otherwise Rust throws us
error[E0317]: `if` may be missing an `else` clause
--> src/main.rs:408:20
|
408 | } else if certificate_model == "device" {
| ____________________^
409 | | CertModel::Device
| | ----------------- found here
410 | | };
| |_____________^ expected `CertModel`, found `()`
|
= note: `if` expressions without `else` evaluate to `()`
= help: consider adding an `else` block that evaluates to the expected type
Plus it protects us if we support more models in the future
twilfredo
reviewed
Jul 15, 2024
twilfredo
approved these changes
Jul 15, 2024
Yeah, it works with both Alias and Device certificates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently only support AliasCert modes.
This PR implements DeviceCert support, with AliasCert still the default. This makes the requester more dynamic and adds the option
--certificate-model deviceto responders to specify the DeviceCert model.