Improve general error handling + PCIe Hex IDs #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twilfredo
force-pushed
the
wilfred/improve-error-handling
branch
from
21e181c to
277c765
Compare
Signed-off-by: Wilfred Mallawa <[email protected]>
twilfredo
force-pushed
the
wilfred/improve-error-handling
branch
from
277c765 to
5d153d5
Compare
alistair23
reviewed
Jul 23, 2024
Signed-off-by: Wilfred Mallawa <[email protected]>
twilfredo
force-pushed
the
wilfred/improve-error-handling
branch
from
1aaa595 to
bb98859
Compare
twilfredo
changed the title
Signed-off-by: Wilfred Mallawa <[email protected]>
Signed-off-by: Wilfred Mallawa <[email protected]>
Signed-off-by: Wilfred Mallawa <[email protected]>
Signed-off-by: Wilfred Mallawa <[email protected]>
Allows the pcie vendor and device ids to be entered in either hex or base 10 format. This should maintain backwards compatibility also. Signed-off-by: Wilfred Mallawa <[email protected]>
twilfredo
force-pushed
the
wilfred/improve-error-handling
branch
from
bb98859 to
597e8ad
Compare
alistair23
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are moving towards a v1.0, let's try to not panic on trivial errors, instead log the error the propagate it up the call stack.
This does come at the cost of more verbose code, I think that's justified when we need to debug, at least we can grep the error message instead of trying to figure out what failed.
Also add support to entering PCIe VID/DevIDs in hex format for the PCIe DOE transport layer. That is
0xprefixed. We still accept base 10 as before as well.