use Appraisal for testing multiple versions of Rails

westonganger · Dec 28, 2018 · ec0bd16 · ec0bd16
1 parent bf7a82a
commit ec0bd16
Show file tree

Hide file tree

Showing 15 changed files with 50 additions and 63 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -2,20 +2,20 @@ language: ruby
 sudo: false
 cache: bundler
 rvm:
-  - 2.2.6
-  - 2.3.3
-  - 2.4.0
+  - 2.3
+  - 2.4
+  - 2.5
   - ruby-head
 
 gemfile:
-  - gemfiles/Gemfile-rails-5.0-stable
-  - gemfiles/Gemfile-rails-5.1-stable
-  - gemfiles/Gemfile-rails-5.0
-  - gemfiles/Gemfile-rails-5.1
+  - gemfiles/Rails_5.0.x
+  - gemfiles/Rails_5.1.x
+  - gemfiles/Rails_5.2.x
 
 matrix:
   allow_failures:
     - rvm: ruby-head
+    - gemfile: gemfiles/Rails_master
 
 notifications:
   email: false
diff --git a/Appraisals b/Appraisals
@@ -0,0 +1,11 @@
+appraise "Rails 5.2.x" do
+  gem "rails", "~> 5.2.0"
+end
+
+appraise "Rails 5.1.x" do
+  gem "rails", "~> 5.1.0"
+end
+
+appraise "Rails 5.0.x" do
+  gem "rails", "~> 5.0.0"
+end
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 * Fix bug related to incorrect usage of options on the AR#new method
 * Use scope_for_create instead of create_scope in Rails 5.2+
 * Fix bug related to protection of `inheritance_column` attribute
+* Use Appraisal for testing against multple Rails versions
 
 ## 1.3.0
 

diff --git a/Gemfile b/Gemfile
@@ -1,5 +1,6 @@
 source 'https://rubygems.org'
 
-gem 'rails', '~>5.0'
+### By default test against Rails v5.2.x, will be overridden by anything in Appraisal file
+gem 'rails', '~>5.2.0'
 
 gemspec
diff --git a/gemfiles/Gemfile-rails-4.2 b/gemfiles/Gemfile-rails-4.2
diff --git a/gemfiles/Gemfile-rails-4.2-stable b/gemfiles/Gemfile-rails-4.2-stable
diff --git a/gemfiles/Gemfile-rails-5.0 b/gemfiles/Gemfile-rails-5.0
diff --git a/gemfiles/Gemfile-rails-5.0-stable b/gemfiles/Gemfile-rails-5.0-stable
diff --git a/gemfiles/Gemfile-rails-5.1 b/gemfiles/Gemfile-rails-5.1
diff --git a/gemfiles/Gemfile-rails-5.1-stable b/gemfiles/Gemfile-rails-5.1-stable
diff --git a/gemfiles/Rails_5.0.x.gemfile b/gemfiles/Rails_5.0.x.gemfile
@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 5.0.0"
+
+gemspec path: "../"
diff --git a/gemfiles/Rails_5.1.x.gemfile b/gemfiles/Rails_5.1.x.gemfile
@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 5.1.0"
+
+gemspec path: "../"
diff --git a/gemfiles/Rails_5.2.x.gemfile b/gemfiles/Rails_5.2.x.gemfile
@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 5.2.0"
+
+gemspec path: "../"
diff --git a/protected_attributes_continued.gemspec b/protected_attributes_continued.gemspec
@@ -16,11 +16,12 @@ Gem::Specification.new do |gem|
   gem.files         = Dir["LICENSE.txt", "README.md", "lib/**/*"]
   gem.require_paths = ["lib"]
 
-  gem.add_dependency "activemodel",  "~>5.0"
+  gem.add_dependency "activemodel",  ">= 5.0"
 
-  gem.add_development_dependency "activerecord", "~>5.0"
-  gem.add_development_dependency "actionpack",   "~>5.0"
-  gem.add_development_dependency "railties",   "~>5.0"
+  gem.add_development_dependency "activerecord", ">= 5.0"
+  gem.add_development_dependency "actionpack",   ">= 5.0"
+  gem.add_development_dependency "railties",   ">= 5.0"
   gem.add_development_dependency "sqlite3"
-  gem.add_development_dependency "mocha"
+  gem.add_development_dependency "mocha", "~> 1.4.0"
+  gem.add_development_dependency 'appraisal'
 end
diff --git a/test/test_helper.rb b/test/test_helper.rb
@@ -3,4 +3,6 @@
 require 'mocha/api'
 require 'rails'
 
+Rails.backtrace_cleaner.remove_silencers!
+
 ActiveSupport.test_order = :random if ActiveSupport.respond_to?(:test_order)