[FIX] Fixed cleaning old files in the export_to method #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -80,9 +80,8 @@ def self.export_to(app_name: nil, zip: false, format: :yaml) | |||
| base_export_path = Rails.root.join("tmp/export/translations/") | |||
|
|
|||
| files_to_delete = Dir.glob("#{base_export_path}/*").each do |f| | |||
| if File.ctime(f) > 1.minutes.ago | |||
| if File.ctime(f) < 1.minutes.ago | |||
| `rm -rf #{f}` | |||
There was a problem hiding this comment.
Looks good but can we change this line to FileUtils.rm_r(f, force: true)
|
I've added one comment. Is it possible we could also add a changelog for this and maybe a spec? |
|
I cant merge this as it needs specs to ensure its working correctly with this new change (which its not) This PR will be replaced by #12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified the condition for file deletion to ensure files older than 1 minute are removed.