REF,TST,BLD,BUG: Python 3 Support #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westurner
commented
Oct 2, 2020
tests/test_pyline.py
Outdated
Comment on lines
399
to
403
| # TODO: decide what to do about sorted([('a', '1'), ('b', None)]) | ||
| # ("w", '-O', 'csv', '-s', '1'), | ||
| # ("w", '-O', 'csv', '-s', '1,2'), | ||
| # ("w", '-O', 'csv', '-S', '1'), | ||
| # ("w", '-O', 'csv', '-S', '1', '-n'), |
There was a problem hiding this comment.
Python 3 fails on:
sorted(['a', None, 1])Due to https://docs.python.org/3/whatsnew/3.0.html#ordering-comparisons
https://stackoverflow.com/a/47368476 is an implementation of Python 2-style sorting for Python 3.
- Ask for permission to use in an open source project
- get permission
- Decide how to enable or disable this feature with CLI args
…y for other sort comparison TypeError exceptions)
westurner
added a commit
that referenced
this pull request
Oct 3, 2020
RLS: pyline v0.3.18 * MRG: Merge tag 'v0.3.17' into develop \[09f46ca\] * REF,TST: Makefile, requirements-test: switch to pytest, require jinja2 for tests \[999446d\] * REF,TST: pyline.py, test_pyline.py: py3 \[7365938\] * WIP: __init__: change import for py3 (TODO: check py2 compatibility) \[fe61a93\] * BLD: requirements\[-test\]: remove wheel, -test -> reqs.txt \[716a9b3\] * REF,BUG: py3, pathpy import, rawstrs, only strip one newline when numbering lines \[f7b3281\] * BLD: tox.ini,.travis.yml: use tox-travis, envs=py37,py38 \[a2a4a82\] * DOC,BLD: docs/reqs,docs/conf: copyright, fix pyline import \[036bac8\] * BLD,TST: setup.py: setup.py:test calls pytest -v \[ced27bb\] * REF,BUG: pyline.py: when sorting, sort None as '' (and log extensively for other sort comparison TypeError exceptions) \[9248acb\] * MRG: #29 REF,TST,BLD,BUG: Python 3 Support \[cb195b4\] * REF: pyline.py: change shebang to \`#!/usr/bin/env python\` from python2 \[5841704\] * RLS: pyline.py,setup.py: v0.3.18 \[a1072e2\] * tag 'v0.3.18': DOC: HISTORY.rst: output from git-changelog.py RLS: pyline.py,setup.py: v0.3.18
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7