Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(au): support multiple AX_KommunalesGebiet per AX_Gemeinde #71

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

florianesser
Copy link
Member

Allow for multiple AX_KommunalesGebiet instances to exist that have the same gemeindekennzeichen. With this patch, the geometries of these AX_KommunalesGebiet instances will be aggregated instead of only one being selected randomly.

SVC-890

Allow for multiple `AX_KommunalesGebiet` instances to exist that have the same
`gemeindekennzeichen`. With this patch, the geometries of these
`AX_KommunalesGebiet` instances will be aggregated instead of only one being
selected randomly.

SVC-890
@florianesser florianesser requested a review from JohannaOtt April 4, 2023 16:44
@JohannaOtt
Copy link
Member

The definition of AX_KommunalesGebiet according to the ATKIS OAK is: 'Kommunales Gebiet' ist ein Teil der Erdoberfläche, der von einer festgelegten Grenzlinie umschlossen ist und den politischen Einflussbereich einer Kommune repräsentiert (z.B. Stadt-, Landgemeinde, gemeindefreies Gebiet).
I read "den politischen Einflussbereich" in a way that there is only one per Gemeinde (not "einen politischen Einflussbereich"). So before reviewing it from a technical point of view, I would like to discuss if that case is allowed at all or if it should rather lead to an error being thrown.
@florianesser Do you read the OAK differently?

If the change is kept after reviewing the definitions etc.: Would it make sense to align it with the code used in the kommunalesGebiet alignment (creating a union)?
If the change is not kept the union should probably be removed from the kommunalesGebiet alignment.

@florianesser
Copy link
Member Author

florianesser commented Apr 5, 2023

Do you read the OAK differently?

@JohannaOtt I would not interpret "den politischen Einfluss" to mean that a Gemeinde cannot have exclaves. There are real-life examples that a Gemeinde can have multiple kommunale Gebiete in the Basis-DLM data of Hessen. Without this patch, the output of the transformation is incomplete.

Would it make sense to align it with the code used in the kommunalesGebiet alignment (creating a union)?

Yes, that might make sense, I'll check that.

@florianesser florianesser marked this pull request as draft April 5, 2023 15:23
@florianesser florianesser removed the request for review from JohannaOtt April 5, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants