Skip to content

Commit

Permalink
ci: fix foundry version
Browse files Browse the repository at this point in the history
  • Loading branch information
@jxom
jxom committed Sep 7, 2024
1 parent c5ecc8f commit 9dc8eab
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/actions/install-dependencies/action.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ runs:
steps:
- name: Set up foundry
uses: foundry-rs/foundry-toolchain@v1
with:
version: nightly-143abd6a768eeb52a5785240b763d72a56987b4a

- name: Set up pnpm
uses: wevm/actions/.github/actions/pnpm@main

4 comments on commit 9dc8eab

@holic
Copy link
Contributor

@holic holic commented on 9dc8eab Sep 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious to hear if something broke in latest nightly

@jxom
Copy link
Member Author

@jxom jxom commented on 9dc8eab Sep 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bug in Anvil where JSON-RPC wouldn’t return “nonce too low” errors. Need to file a bug (will do tomorrow).

@jxom
Copy link
Member Author

@jxom jxom commented on 9dc8eab Sep 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, looks like nonces are ignored now for estimateGas: foundry-rs/foundry#8814 (comment)

@holic
Copy link
Contributor

@holic holic commented on 9dc8eab Sep 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting! do geth/reth ignore nonce during estimateGas? TIL

Please sign in to comment.