Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: protected action types #1435

Merged
merged 2 commits into from
Nov 2, 2023
Merged

fix: protected action types #1435

merged 2 commits into from
Nov 2, 2023

Conversation

tmm
Copy link
Member

@tmm tmm commented Nov 2, 2023

Fixes protected action types for writeContract

Copy link

changeset-bot bot commented Nov 2, 2023

🦋 Changeset detected

Latest commit: 46b57a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem ✅ Ready (Inspect) Visit Preview Nov 2, 2023 5:12pm

Comment on lines +45 to +47
FormattedTransactionRequest<
TChainOverride extends Chain ? TChainOverride : TChain
>['value']
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More direct way to get value.

Copy link
Contributor

github-actions bot commented Nov 2, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
viem (esm) 58.26 KB (0%) 1.2 s (0%) 1.6 s (+10.7% 🔺) 2.8 s
viem (cjs) 77.28 KB (0%) 1.6 s (0%) 2.1 s (-2.4% 🔽) 3.6 s
viem (minimal surface - tree-shaking) 3.89 KB (0%) 78 ms (0%) 296 ms (-19.92% 🔽) 374 ms
viem/accounts 89.01 KB (0%) 1.8 s (0%) 912 ms (-3.83% 🔽) 2.7 s
viem/accounts (tree-shaking) 19.37 KB (0%) 388 ms (0%) 363 ms (-34.02% 🔽) 751 ms
viem/actions 43.33 KB (0%) 867 ms (0%) 6.6 s (-1.43% 🔽) 7.5 s
viem/actions (tree-shaking) 350 B (0%) 10 ms (0%) 229 ms (+48.91% 🔺) 239 ms
viem/chains 18.67 KB (0%) 374 ms (0%) 725 ms (+44.97% 🔺) 1.1 s
viem/chains (tree-shaking) 470 B (0%) 10 ms (0%) 242 ms (+18.56% 🔺) 252 ms
viem/chains/utils 9.18 KB (0%) 184 ms (0%) 323 ms (+12.49% 🔺) 507 ms
viem/chains/utils (tree-shaking) 5.36 KB (0%) 108 ms (0%) 286 ms (-16.1% 🔽) 393 ms
viem/ens 43.33 KB (0%) 867 ms (0%) 6.7 s (+3.31% 🔺) 7.5 s
viem/ens (tree-shaking) 18.02 KB (0%) 361 ms (0%) 537 ms (-11.96% 🔽) 897 ms

@jxom jxom merged commit 08e6a68 into main Nov 2, 2023
17 of 25 checks passed
@jxom jxom deleted the tmm/fix-protected-action-types branch November 2, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants