fix: viem/node esm/cjs conflict #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 836ff50 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tmm
force-pushed
the
tmm/node-export-fix
branch
2 times, most recently
from
7357716
to
79abf44
Compare
tmm
commented
May 23, 2024
| @@ -6,8 +6,10 @@ | |||
| "bench": "vitest bench", | |||
| "bench:ci": "CI=true vitest bench", | |||
| "build": "bun run clean && bun run build:cjs && bun run build:esm && bun run build:types", | |||
| "build:cjs": "tsc --project ./tsconfig.build.json --module commonjs --outDir ./src/_cjs --removeComments --verbatimModuleSyntax false && printf '{\"type\":\"commonjs\"}' > ./src/_cjs/package.json", | |||
| "build:cjs": "bun run build:trustedSetups:start && tsc --project ./tsconfig.build.json --module commonjs --outDir ./src/_cjs --removeComments --verbatimModuleSyntax false && printf '{\"type\":\"commonjs\"}' > ./src/_cjs/package.json && bun run build:trustedSetups:end", | |||
There was a problem hiding this comment.
move commonjs version trustedSetups_cjs.ts to trustedSetups.ts, then cleans up at the end
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2298 +/- ##
==========================================
- Coverage 99.70% 99.69% -0.01%
==========================================
Files 680 680
Lines 57684 57692 +8
Branches 2749 2749
==========================================
+ Hits 57511 57518 +7
Misses 156 156
- Partials 17 18 +1 ☔ View full report in Codecov by Sentry. |
jxom
approved these changes
May 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds CJS and ESM versions of
trustedSetups.tsand uses specific one based on the build type.Fixes #2297
Alternative approach could be creating a
'viem/node/trustedSetups'entrypoint, chucking the compiled files in there, and exporting those in'viem/node'.PR-Codex overview
This PR focuses on adding support for ESM (ECMAScript Modules) for trusted setups in the project.
Detailed summary
src/node/trustedSetups_esm.tsfor ESM supporttsconfig.build.jsonfor ESM module resolution