Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] update: Abstract testnet EIP712 domain #2687

Closed
wants to merge 2 commits into from
Closed

[WIP] update: Abstract testnet EIP712 domain #2687

wants to merge 2 commits into from

Conversation

cygaar
Copy link
Contributor

@cygaar cygaar commented Sep 3, 2024 •
edited by pr-codex bot
Loading

The default domain name for zk stack chains right now is zkSync. However, on Abstract, we want the domain name to be Abstract. This PR changes the network configuration to default to Abstract.

PR-Codex overview

The focus of this PR is to add a new function getAbstractEip712Domain and update abstractTestnet chain configuration with a custom EIP712 domain.

Detailed summary

  • Added getAbstractEip712Domain function to generate EIP712 domain for Abstract chain
  • Updated abstractTestnet chain configuration to use the new EIP712 domain function

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2024

⚠️ No Changeset found

Latest commit: 29b6f7e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Sep 3, 2024

@cygaar is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

@cygaar cygaar changed the title update: Abstract testnet 712 domain update: Abstract testnet EIP712 domain Sep 3, 2024
@cygaar cygaar changed the title update: Abstract testnet EIP712 domain [WIP] update: Abstract testnet EIP712 domain Sep 5, 2024
@jxom jxom force-pushed the main branch 3 times, most recently from b56e162 to ad2831b Compare September 7, 2024 02:46
@jxom jxom mentioned this pull request Sep 9, 2024
Merged
@jxom
Copy link
Member

jxom commented Sep 9, 2024

superseded by #2709

@jxom jxom closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cygaar @jxom