Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: abstract testnet 712 domain #2709

Merged
merged 4 commits into from
Sep 9, 2024
Merged

feat: abstract testnet 712 domain #2709

merged 4 commits into from
Sep 9, 2024

Conversation

jxom
Copy link
Member

@jxom jxom commented Sep 9, 2024

supersedes #2687


PR-Codex overview

This PR focuses on adding a function transactionToMessage in getEip712Domain.ts and importing it in abstractTestnet.ts for EIP712 domain creation.

Detailed summary

  • Exported transactionToMessage function in getEip712Domain.ts
  • Imported transactionToMessage in abstractTestnet.ts for EIP712 domain creation

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem ✅ Ready (Inspect) Visit Preview Sep 9, 2024 10:17pm

Copy link

changeset-bot bot commented Sep 9, 2024

⚠️ No Changeset found

Latest commit: 45ffb42

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jxom jxom merged commit 1f5ec79 into main Sep 9, 2024
2 of 4 checks passed
@jxom jxom deleted the abstract-712 branch September 9, 2024 21:58
Copy link
Contributor

github-actions bot commented Sep 9, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
import * from 'viem' (esm) 60.91 KB (0%) 1.3 s (0%) 11.8 s (+6.53% 🔺) 13.1 s
const viem = require('viem') (cjs) 71.13 KB (0%) 1.5 s (0%) 12.9 s (-37.31% 🔽) 14.3 s
import { createClient, http } from 'viem' 6.24 KB (0%) 125 ms (0%) 821 ms (+127.82% 🔺) 945 ms
import * from 'viem/account-abstraction' 43.92 KB (0%) 879 ms (0%) 8.9 s (+52.36% 🔺) 9.8 s
import { toCoinbaseSmartAccount } from 'viem/account-abstraction' 34 KB (+0.03% 🔺) 681 ms (+0.03% 🔺) 4.3 s (-1.74% 🔽) 5 s
import * from 'viem/accounts' 81.01 KB (0%) 1.7 s (0%) 5.1 s (-12.94% 🔽) 6.7 s
import { privateKeyToAccount } from 'viem/accounts' 19.42 KB (0%) 389 ms (0%) 1.5 s (+87.88% 🔺) 1.9 s
import * from 'viem/actions' 46 KB (0%) 921 ms (0%) 8.6 s (+7.44% 🔺) 9.5 s
import { getBlockNumber } from 'viem/actions' 318 B (0%) 10 ms (0%) 28 ms (-14.71% 🔽) 38 ms
import * from 'viem/chains' 36.28 KB (0%) 726 ms (0%) 9.7 s (+34.3% 🔺) 10.4 s
import { mainnet } from 'viem/chains' 324 B (0%) 10 ms (0%) 47 ms (-14.29% 🔽) 57 ms
import * from 'viem/chains/utils' 1.08 KB (0%) 22 ms (0%) 71 ms (+23.26% 🔺) 93 ms
import * from 'viem/ens' 45.44 KB (0%) 909 ms (0%) 6.9 s (-0.38% 🔽) 7.8 s
import { getEnsAvatar } from 'viem/ens' 22.17 KB (0%) 444 ms (0%) 3.7 s (-42.63% 🔽) 4.2 s
import * from 'viem/siwe' 30.24 KB (0%) 605 ms (0%) 5 s (-28.9% 🔽) 5.6 s
import { verifySiweMessage } from 'viem/siwe' 29.15 KB (-0.08% 🔽) 583 ms (-0.08% 🔽) 6.1 s (-13.68% 🔽) 6.7 s

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 17.14286% with 29 lines in your changes missing coverage. Please review.

Project coverage is 99.58%. Comparing base (7bdb6f9) to head (45ffb42).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/chains/definitions/abstractTestnet.ts 14.70% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2709      +/-   ##
==========================================
- Coverage   99.63%   99.58%   -0.06%     
==========================================
  Files         792      792              
  Lines       70892    70926      +34     
  Branches     3300     3299       -1     
==========================================
- Hits        70632    70629       -3     
- Misses        243      279      +36     
- Partials       17       18       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants