Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Abstract EIP712 domain changes #2724

Merged
merged 3 commits into from
Sep 15, 2024
Merged

Revert Abstract EIP712 domain changes #2724

merged 3 commits into from
Sep 15, 2024

Conversation

cygaar
Copy link
Contributor

@cygaar cygaar commented Sep 14, 2024

It turns out, the zkSync domain name is hardcoded into the bootloader, meaning we can't change this domain in our code without modifying the node directly.


PR-Codex overview

This PR reverts custom EIP712 domain changes in viem and removes related functions from abstractTestnet.

Detailed summary

  • Reverted custom EIP712 domain changes in viem.
  • Removed getEip712Domain function from abstractTestnet.
  • Updated transactionToMessage to be an exported function in getEip712Domain.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Sep 14, 2024

🦋 Changeset detected

Latest commit: dc5e2ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 14, 2024

@cygaar is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

@jxom jxom merged commit c2b2c78 into wevm:main Sep 15, 2024
12 of 26 checks passed
@github-actions github-actions bot mentioned this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants