Revert Abstract EIP712 domain changes #2724
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out, the
zkSync
domain name is hardcoded into the bootloader, meaning we can't change this domain in our code without modifying the node directly.PR-Codex overview
This PR reverts custom EIP712 domain changes in
viem
and removes related functions fromabstractTestnet
.Detailed summary
viem
.getEip712Domain
function fromabstractTestnet
.transactionToMessage
to be an exported function ingetEip712Domain.ts
.