fix: add parseEip712Transaction util function #2948
Conversation
|
|
@nikola-bozin-txfusion is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
| export function parseEip712Transaction( | ||
| transaction: Hex, | ||
| ): ZksyncTransactionSerializableEIP712 { | ||
| { |
There was a problem hiding this comment.
Is the scope required here (L14 + L21)?
| throw new BaseError('transaction type must be eip712') | ||
| } | ||
|
|
||
| return constructEip712Transaction(payload) |
There was a problem hiding this comment.
Can we inline the contents of constructEip712Transaction into here?
There was a problem hiding this comment.
The constructEip712Transaction method is inlined.
| type PaymasterParams = { | ||
| paymaster: Hex | ||
| paymasterInput: Hex | ||
| } |
There was a problem hiding this comment.
Do we need to explicitly define this type? The handleArrayToPaymaster return type should be inferred.
There was a problem hiding this comment.
PaymasterParams is not needed and it has been removed.
|
Can we please add an export & docs for this? Also needs a changeset. |
danijelTxFusion
force-pushed
the
kiriyaga-txfusion-parse-eip-712
branch
from
0620294
to
09689f7
Compare
danijelTxFusion
force-pushed
the
kiriyaga-txfusion-parse-eip-712
branch
from
09689f7
to
5f8b1d3
Compare
PR-Codex overview
This PR introduces the
parseEip712Transactionfunction to handle EIP-712 transactions in thezksyncproject. It includes validation for transaction types, parsing of paymaster parameters, and tests for various scenarios, ensuring robust handling of serialized transactions.Detailed summary
parseEip712Transactionfunction insrc/zksync/utils/parseEip712Transaction.ts.validHexandparsePaymasterArray.src/zksync/utils/parseEip712Transaction.test.tsfor: