-
-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for openSUSE/SUSE #5407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for diving in!
docs/install/linux.md
Outdated
|
||
!!! note | ||
It is recommended that you install via Copr so that it is easiest | ||
to stay up to date as future versions of wezterm are released. | ||
If you want nightly versions of WezTerm, it is recommended to use Copr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may disagree, but from my perspective, I know what is in the copr builds and I don't know what the suse (or any other distro) maintainers may have done to the builds they produce, which makes it a bit easier for me to reason about and provide support if folks are running my builds.
I'd prefer to revert this part of the PR back to what I originally wrote.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted my changes. Since you are the maintainer, I rely on your expertise here. However, when someone reads this note, it may imply to always use the nightly builds instead of the stable releases.
If you are interested in what openSUSE maintainers are doing/modifying in WezTerm on openSUSE, take a look at the packages in the OBS or directly at the .spec
file. The interesting part begins at line 105.
Thank you, Wez, for the quick review and the suggestions. I added your suggestions in a separate commit for an easier review, and also rebased the branch. When the PR gets approved, I can squash the temporary commit into the correct one before you merge it. |
dc6596a
to
3bf4998
Compare
@wez I did a rebase and would appreciate another review 😉 |
These 2 dependencies are not needed when building from source. I tested this for Tumbleweed, Slowroll and Leap 15.5. Signed-off-by: Dominik Gedon <[email protected]>
- Mention different flavours of openSUSE and how to install WezTerm there. - The recommended way is always via the official repositories. However, this is not possible for Leap 15.5 as of now. Signed-off-by: Dominik Gedon <[email protected]>
Signed-off-by: Dominik Gedon <[email protected]>
@wez As another openSUSE user I would also like to see a review on this. The current SUSE installation instructions still recommends adding the openSUSE:Factory repo which is unsafe and not needed and this PR fixes that |
Thanks! |
* get-deps: remove not needed deps for openSUSE/SUSE These 2 dependencies are not needed when building from source. I tested this for Tumbleweed, Slowroll and Leap 15.5. Signed-off-by: Dominik Gedon <[email protected]> * docs: Update docs for openSUSE/SUSE - Mention different flavours of openSUSE and how to install WezTerm there. - The recommended way is always via the official repositories. However, this is not possible for Leap 15.5 as of now. Signed-off-by: Dominik Gedon <[email protected]> * TMP: address suggestions from @wez Signed-off-by: Dominik Gedon <[email protected]> --------- Signed-off-by: Dominik Gedon <[email protected]>
This PR
When using Copr on openSUSE distros, you need to specify which repository you want to use, otherwise the command will fail:
The same with a repository works:
However, the installation from source afterwards was successful.
Tests/linting
I ran
as mentioned in the contribution guide, but was not able to get the tests to pass, although I did not touch the code of WezTerm itself.