Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS notch avoidance padding in full screen mode #5515

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Fix macOS notch avoidance padding in full screen mode #5515

merged 1 commit into from
Jun 8, 2024

Commits on Jun 4, 2024

  1. Fix notch avoidance padding in full screen mode

    Fixes #3807
    
    The values returned by [`safeAreaInsets`][0] need to be multipled by the
    scale factor of the display (in case of the MacBook Pro 14-inch, 2021, a
    value of 2.0).
    
    There's a code comment referencing [#1737 (comment)][1], where an extra
    `2` was added to this number, but something must have changed since then
    because I cannot see a need for this now.
    
    [0]: https://developer.apple.com/documentation/appkit/nsscreen/3882821-safeareainsets
    [1]: #1737 (comment)
    mbaird committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    52bbd3a View commit details
    Browse the repository at this point in the history