Restrict bell events to the proper window. #6012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the comment in mod.rs, bell events are sent to all windows; not just the window containing the pane which generated the event. To prevent each bell ringing multiple times, the window event handler must check if it has the pane, and ignore the bell event if it doesn't. This fixes bug wez#5985
wez
reviewed
Sep 14, 2024
|
Made the change, and the diff looks more presentable :-) I added, a second commit with the changes, but I could squash them instead if preferred. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the comment in mod.rs, bell events are sent to all windows; not just the window containing the pane which generated the event.
To prevent each bell ringing multiple times, the window event handler must check if it has the pane, and ignore the bell event if it doesn't.
This fixes bug #5985