Use serial2 crate instead of serial #6411
Open
+38
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeevithakannan2
force-pushed
the
serial2
branch
from
2e347f2
to
58254b9
Compare
wez
reviewed
Nov 19, 2024
There was a problem hiding this comment.
Thanks for this!
It's currently breaking the API for existing consumers by removing some important configuration options, and we need to reconcile that.
If we cannot retain the current interface then we need to have a strategy and suggestion in place for users when they upgrade, and importantly, we need to bump the pty crate version to 0.9.0 to safely indicate that the API is not backwards compatible.
Added API methods back now it should not the break the APIs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The serial crate is not maintained has heavy dependencies. An alternative to serial is serial2 an actively maintained crate.