feat: allow editing old sessions via popup dialog #798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Related Issue(s)
Description
The existing code structure was quite nested and involved a lot of prop drilling.
Many parts of the UI depended on each other, and attempting to refactor everything to insert editing logic would risk breaking the flow or functionality.
Instead of trying to untangle the entire structure, I went for a simpler and more isolated approach by adding an editable popup dialog.
This keeps the current structure intact while still allowing the session to be updated efficiently.
I reused your existing logic and helper functions wherever possible to keep the behavior consistent.
Functionally, the popup works identically to the original workflow but with less complexity.