Skip to content

Commit

Permalink
apacheGH-40775: [Benchmarking][Java] Fix conbench timeout (apache#40786)
Browse files Browse the repository at this point in the history
### Rationale for this change

The java build script has been recently updated and it is affecting conbench, which is now seeing timeouts when building java. The logs are producing 100s of GB of data due to an unnecessary debug log msg.

### What changes are included in this PR?

* Delete log message on write to memory

### Are these changes tested?

Yes, via conbench

### Are there any user-facing changes?

No
* GitHub Issue: apache#40775

Authored-by: Dane Pitkin <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
  • Loading branch information
danepitkin authored Apr 5, 2024
1 parent 1a1d2c8 commit 139afe5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,12 @@ public void testMemoryUsage() {
break;
}
}
assertTrue("Log messages are:\n" +
synchronized (memoryLogsAppender.list) {
assertTrue("Log messages are:\n" +
memoryLogsAppender.list.stream().map(ILoggingEvent::toString).collect(Collectors.joining("\n")),
result);
result);
}

} finally {
memoryLogsAppender.stop();
logger.detachAppender(memoryLogsAppender);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,6 @@ public long align() throws IOException {
*/
public long write(ByteBuffer buffer) throws IOException {
long length = buffer.remaining();
if (LOGGER.isDebugEnabled()) {
LOGGER.debug("Writing buffer with size: {}", length);
}
while (buffer.hasRemaining()) {
out.write(buffer);
}
Expand Down

0 comments on commit 139afe5

Please sign in to comment.