Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: translate facts to esp-mx localization #308

Merged
merged 1 commit into from
Aug 8, 2023
Merged

chore: translate facts to esp-mx localization #308

merged 1 commit into from
Aug 8, 2023

Conversation

Whiskydog
Copy link
Contributor

@Whiskydog Whiskydog commented Aug 5, 2023

Description of changes

  • Created a new branch which...
  • Translates all 89 English facts to the esp-mx localization in src/models/localizations/esp-mx.js
  • Removes unnecessary catfacts facts (last two).
  • All tests green.

Resolves #209 however I couldn't manage to add any new facts relevant to the region.

Also, working on Windows and I had to add { endOfLine: "auto" } to the prettier rules in .eslintrc.js because it was complaining about the CR character. Irrelevant to the PR so I didn't commit it, but might want to check on that. 😅

Please feel free to provide any feedback, this'd be my first PR! ❤️

Copy link
Member

@BeauBouchard BeauBouchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job! I appreciate all the effort that went into this localization.

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #308 (430a685) into main (ad3e0aa) will increase coverage by 0.56%.
Report is 19 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
+ Coverage   90.76%   91.32%   +0.56%     
==========================================
  Files          17       19       +2     
  Lines         184      196      +12     
==========================================
+ Hits          167      179      +12     
  Misses         17       17              
Files Changed Coverage Δ
src/models/localizations/ces-cz.js 100.00% <ø> (ø)
src/models/localizations/eng-us.js 100.00% <ø> (ø)
src/models/localizations/esp-mx.js 100.00% <ø> (ø)
src/models/localizations/zho-tw.js 100.00% <ø> (ø)
src/models/localizations/ita-it.js 100.00% <100.00%> (ø)
src/models/localizations/kor-ko.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BeauBouchard BeauBouchard merged commit 47b9d16 into wh-iterabb-it:main Aug 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[i18n] Español MX
2 participants