This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Try to use line buffering in postoffice #2397
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to use line buffering in the postoffice UDS connection. In addition, reuse the same client for all connections instead of streaming one connection at a time. Signed-off-by: Joe Grund <[email protected]>
utopiabound
suggested changes
Nov 24, 2020
| })?; | ||
| let mut incoming = listener.incoming().take_until(tripwire); | ||
|
|
||
| let conn = UnixStream::connect(&addr) |
There was a problem hiding this comment.
Why is this changing? This side should be the server listening for connections right?
There was a problem hiding this comment.
How many writers will there be on a socket at once?
There was a problem hiding this comment.
current usage between 0 and number of mounted targets.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to use line buffering in the postoffice UDS connection.
In addition, reuse the same client for all connections instead of
streaming one connection at a time.
Signed-off-by: Joe Grund [email protected]
This change is