Adding ability to create accounts directly from plugin UI

[dafuga]

No description provided.

[dafuga]

I was seeing some type mismatch errors when using the newer session kit version.

[aaroncox]

Yeah I wouldn't use a RC version for the release version. Those are subject to change and might have bugs. It might be required here though?

[aaroncox]

Yeah - it requires the RC version to work. The 1.4.0 release introduces the key lookup mechanism that this plugin requires.

[dafuga]

What key lookup mechanism? 😅 I think I might have missed that part lol.

[aaroncox]

The web-renderer (1.4.0-rc6) and session (1.4.x) does automatic key lookups now if a wallet provides a public key method:

https://github.com/wharfkit/web-renderer/blob/75b432fc77a57b455ffc72ee5384a988a66b4d6b/src/ui/login/Permission.svelte#L37-L45

That automatically retrieves the key and then does a lookup, displaying the accounts you can login with.

The metamask plugin implements this method, so it just automatically does lookups.

wallet-plugin-metamask/src/index.ts

Lines 93 to 103 in ae23425

	async retrievePublicKey(chainId: Checksum256Type): Promise<PublicKey> {
	await this.initialize()
	if (!this.provider) {
	throw new Error('Metamask not found')
	}
	const result = (await this.invokeSnap({
	method: 'antelope_getPublicKey',
	params: {chainId: String(chainId)},
	})) as string
	return PublicKey.from(result)
	}

This part of the web-renderer might be a place we could inject some sort of plugin to create an account?

[dafuga]

Oh sweet! And for the account creation, we would need to display a button to trigger that somewhere, right? I was thinking that we could have the session kit handle displaying that button when a compatible account creation plugin is available.

[aaroncox]

Ideally yeah - if a creation plugin was available, we could show it in a few different spots.

I don't think the account creation plugin UI was developed like that though - and instead I think it was meant to be manually triggered by the developer 🤔

So we may need some web-renderer changes.

[dafuga]

Yeah, right now you need to trigger it with the sessionKit.createAccount() method. And yeah, we probably need to make some changes to the web renderer to make the UX better on that front.

[aaroncox]

I don't think there's any value in deriving the owner and active key from different parts of the mnemonic.

Both of those keys are derived from the same place, and stored in the same place... so if one gets stolen the other will too.

For these accounts I think we should just use the same key for both. Maybe in the future we could add a feature to generate an owner key certificate or something, so that they'd actually have two separate keys.

So here it'd just:

• Make the keys both default to index 0.
• Remove the index parameter from retrievePublicKey (since its unused)

[dafuga]

Hmm you may be right.. it's good practice to use different keys but in this case since the keys can't be exported I guess there is no risk of the active key being leaked somehow 🤔

[aaroncox]

You shouldn't have to prompt this, the web-renderer should do this 🤔

[dafuga]

I could be missing something, but as far as I could tell, there was no way to have the web renderer prompt the user to select a permission while also giving him the option to create a new account so that's why I ended up with something like this.

[dafuga]

Closing this PR since we decided that the account creation logic shouldn't be in the wallet plugin.