Allowing snap origin arg on plugin initialization #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafuga
force-pushed
the
allowing-snap-origin-arg
branch
from
2ca12ca
to
78e5c03
Compare
dafuga
force-pushed
the
allowing-snap-origin-arg
branch
2 times, most recently
from
80e2673
to
3955f60
Compare
dafuga
force-pushed
the
allowing-snap-origin-arg
branch
from
3955f60
to
d4b286a
Compare
aaroncox
approved these changes
Aug 22, 2024
src/index.ts
Outdated
| const defaultSnapOrigin = 'local:http://localhost:8080' | ||
| // const defaultSnapOrigin = 'npm:@greymass/test-snap' | ||
|
|
||
| export class WalletPluginMetaMask extends AbstractWalletPlugin implements WalletPlugin { | ||
| public id = 'wallet-plugin-metamask' | ||
| snapOrigin: string |
There was a problem hiding this comment.
Should this be public or readonly?
There was a problem hiding this comment.
I can make it public 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.