fix: cover uncovered tests areas & fix fieldset nesting & fix datetim…

…e input fp-68

readme.md

@@ -72,14 +72,14 @@ PS. _The library works perfectly with any framework. Just use a valid [HTMLFormE
 | [HTMLInputElement](https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement)       | `type="url"`                 | ✅       | `string`                                                                                        |
 | [HTMLInputElement](https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement)       | `type="tel"`                 | ✅       | `string`                                                                                        |
 | [HTMLInputElement](https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement)       | `type="color"`               | ✅       | `string`                                                                                        |
+| [HTMLInputElement](https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement)       | `type="datetime-local"`      | ✅       | `string`                                                                                        |
 | [HTMLInputElement](https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement)       | `type="radio"`               | ✅       | `string`                                                                                        |
 | [HTMLInputElement](https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement)       | `type="hidden"`              | ✅       | `string`                                                                                        |
 | [HTMLInputElement](https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement)       | `type="number"`              | ✅       | `number`                                                                                        |
 | [HTMLInputElement](https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement)       | `type="range"`               | ✅       | `number`                                                                                        |
 | [HTMLInputElement](https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement)       | `type="checkbox"`            | ✅       | `boolean`                                                                                       |
 | [HTMLInputElement](https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement)       | `type="date"`                | ✅       | [`Date`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date) |
 | [HTMLInputElement](https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement)       | `type="time"`                | ✅       | [`Date`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date) |
-| [HTMLInputElement](https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement)       | `type="datetime-local"`      | ✅       | [`Date`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date) |
 | [HTMLInputElement](https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement)       | `type="month"`               | ✅       | [`Date`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date) |
 | [HTMLInputElement](https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement)       | `type="week"`                | ✅       | [`Date`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date) |
 | [HTMLInputElement](https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement)       | `type="file"`                | ✅       | [`File`](https://developer.mozilla.org/en-US/docs/Web/API/File) or `null`                       |
@@ -93,7 +93,5 @@ PS. _The library works perfectly with any framework. Just use a valid [HTMLFormE
 | [HTMLSelectElement](https://developer.mozilla.org/en-US/docs/Web/API/HTMLSelectElement)     | `multiple`                   | ✅       | `Array<string>`                                                                                 |
 | [HTMLOutputElement](https://developer.mozilla.org/en-US/docs/Web/API/HTMLOutputElement)     | –                            | ✅       | `string`                                                                                        |
 | [HTMLFieldsetElement](https://developer.mozilla.org/en-US/docs/Web/API/HTMLFieldsetElement) | –                            | ✅       | `Object<name: string, value: unknown>` (recursive values of nested elements)                    |
-| [HTMLButtonElement](https://developer.mozilla.org/en-US/docs/Web/API/HTMLButtonElement)     | `type="button"`              | ❌       | –                                                                                               |
-| [HTMLButtonElement](https://developer.mozilla.org/en-US/docs/Web/API/HTMLButtonElement)     | `type="submit"`              | ❌       | –                                                                                               |
-| [HTMLButtonElement](https://developer.mozilla.org/en-US/docs/Web/API/HTMLButtonElement)     | `type="reset"`               | ❌       | –                                                                                               |
+| [HTMLButtonElement](https://developer.mozilla.org/en-US/docs/Web/API/HTMLButtonElement)     | –                            | ❌       | –                                                                                               |
 | [HTMLObjectElement](https://developer.mozilla.org/en-US/docs/Web/API/HTMLObjectElement)     | –                            | ❌       | –                                                                                               |

src/libs/constants/constants.js

@@ -1,2 +1 @@
 export { BANNED_CONTROL_TYPES } from './banned-control-types.constant.js';
-export { BANNED_FORM_OPERATIONAL_CONTROL_ELEMENTS } from './banned-form-operational-control-elements.constant.js';

src/libs/enums/control-type.enum.js

@@ -6,6 +6,7 @@ const ControlType = /** @type {const} */ ({
 	URL: 'url',
 	TEL: 'tel',
 	COLOR: 'color',
+	DATETIME_LOCAL: 'datetime-local',
 	RADIO: 'radio',
 	HIDDEN: 'hidden',
 
@@ -16,7 +17,6 @@ const ControlType = /** @type {const} */ ({
 
 	DATE: 'date',
 	TIME: 'time',
-	DATETIME_LOCAL: 'datetime-local',
 	MONTH: 'month',
 	WEEK: 'week',
 

src/libs/maps/element-name-to-element-instance.map.js

@@ -0,0 +1,6 @@
+const bannedElementNameToElementInstance = /** @type {const} */ ({
+	button: HTMLButtonElement,
+	object: HTMLObjectElement,
+});
+
+export { bannedElementNameToElementInstance };

src/libs/maps/maps.js

@@ -0,0 +1 @@
+export { bannedElementNameToElementInstance } from './element-name-to-element-instance.map.js';

src/packages/get-form-control-payload/get-form-control-payload.js

@@ -57,6 +57,7 @@ const getFormControlPayload = (controlNode) => {
 		case ControlType.URL:
 		case ControlType.TEL:
 		case ControlType.COLOR:
+		case ControlType.DATETIME_LOCAL:
 		case ControlType.RADIO:
 		case ControlType.HIDDEN:
 		case ControlType.TEXTAREA:
@@ -84,7 +85,6 @@ const getFormControlPayload = (controlNode) => {
 		}
 		case ControlType.DATE:
 		case ControlType.TIME:
-		case ControlType.DATETIME_LOCAL:
 		case ControlType.MONTH:
 		case ControlType.WEEK: {
 			return getInputDateValue(
@@ -113,7 +113,7 @@ const getFormControlPayload = (controlNode) => {
 	}
 
 	throw new FormPayloadError({
-		message: 'Unknown control type.',
+		message: `Unsupported control type – ${controlNode.type}.`,
 	});
 };
 

src/packages/get-form-control-payload/helpers/check-is-refer-to-another-node/check-is-refer-to-another-node.helper.js

@@ -8,13 +8,16 @@
  */
 const checkIsReferToAnotherNode = (currentNode, ...checkNodes) => {
 	return checkNodes.some((checkNode) => {
-		const hasElements = 'elements' in checkNode;
+		const hasElements =
+			'elements' in checkNode && checkNode.elements.length > 0;
 
 		if (!hasElements) {
 			return false;
 		}
 
-		return Boolean(checkNode.elements.namedItem(currentNode.name));
+		return [...checkNode.elements].some((element) =>
+			element.contains(currentNode),
+		);
 	});
 };
 

src/packages/get-form-control-payload/helpers/get-allowed-elements/get-allowed-elements.helper.js

@@ -1,7 +1,5 @@
-import {
-	BANNED_CONTROL_TYPES,
-	BANNED_FORM_OPERATIONAL_CONTROL_ELEMENTS,
-} from '../../../../libs/constants/constants.js';
+import { BANNED_CONTROL_TYPES } from '../../../../libs/constants/constants.js';
+import { bannedElementNameToElementInstance } from '../../../../libs/maps/maps.js';
 
 /** @typedef {import('../../../../libs/types/types.js').HTMLFormControlElement} HTMLFormControlElement */
 /** @typedef {import('../../../../libs/types/types.js').HTMLFormOperationalControlElement} HTMLFormOperationalControlElement */
@@ -30,13 +28,13 @@ const checkControlFunctionMap = /** @type {const} */ ({
 	 * @returns {boolean}
 	 */
 	checkIsAllowedElement(element) {
-		const isObjectNode = BANNED_FORM_OPERATIONAL_CONTROL_ELEMENTS.some(
-			(node) => {
-				return element instanceof node;
-			},
-		);
+		const isSameNode = Object.values(
+			bannedElementNameToElementInstance,
+		).some((node) => {
+			return element instanceof node;
+		});
 
-		return !isObjectNode;
+		return !isSameNode;
 	},
 });