feat: add exception on elements without type fp-103 (#113)

what1s1ove · Dec 10, 2023 · 6ec99ca · 6ec99ca
1 parent b3f4315
commit 6ec99ca
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/packages/get-form-control-payload/get-form-control-payload.js b/src/packages/get-form-control-payload/get-form-control-payload.js
@@ -51,6 +51,14 @@ const getFormControlsPayload = (...controlElements) => {
  * @throws {FormPayloadError}
  */
 const getFormControlPayload = (controlNode) => {
+	const hasType = 'type' in controlNode;
+
+	if (!hasType) {
+		throw new FormPayloadError({
+			message: 'Control element has no type attribute.',
+		});
+	}
+
 	switch (controlNode.type) {
 		case ControlType.TEXT:
 		case ControlType.PASSWORD:
@@ -129,7 +137,7 @@ const getFormControlPayload = (controlNode) => {
 	}
 
 	throw new FormPayloadError({
-		message: `Unsupported control type – ${controlNode.type}.`,
+		message: `Unsupported control element type – ${controlNode.type}.`,
 	});
 };
 

diff --git a/tests/get-form-control-payload.test.js b/tests/get-form-control-payload.test.js
@@ -428,6 +428,12 @@ describe('getFormControlPayload should work correctly', () => {
 	});
 
 	describe('should work correctly with an unexpected control type', () => {
+		test('should throw FormPayloadError for elements without type', () => {
+			const control = /** @type {HTMLInputElement} */ ({});
+
+			throws(() => getFormControlPayload(control), FormPayloadError);
+		});
+
 		test('should throw FormPayloadError with unknown input type', () => {
 			const control = /** @type {HTMLInputElement} */ ({
 				type: 'unknown-type',