editorial: move dialog content attributes above properties #10969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
requested changes
Jan 31, 2025
There was a problem hiding this comment.
As mentioned in #10965 (review) I think "markup things" / "the core of the element" should stay together, ahead of the public API and processing model.
domenic
added
clarification
keithamus
force-pushed
the
editorial-move-dialog-content-attributes-above-properties
branch
from
4bbeb2c to
12de605
Compare
|
Ah I think this one then becomes redundant, so I'll close. |
keithamus
deleted the
editorial-move-dialog-content-attributes-above-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This editorial PR (refs #10963) moves content attributes down to where properties will be defined; around the same area as the concepts, below the public methods.
/interactive-elements.html ( diff )