Update 'destination' for navigation requests. #4976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
reviewed
Nov 4, 2019
source
Outdated
| <li><p>If <var>browsingContext</var>'s <span>browsing context container</span> is an | ||
| <code>iframe</code> element, set <var>request</var>'s <span | ||
| data-x="concept-request-destination">destination</span> to "<code | ||
| data-x="">iframe</code>".</p></li> |
There was a problem hiding this comment.
What would go wrong if we set it to browsing context container's local name?
There was a problem hiding this comment.
That might be an elegant way of replacing all this text with something simpler. Hrm. Assuming portal does the same thing (which is a reasonable thing to expect), it seems pretty future-proof.
Let me think about it for a minute, but I don't see any obvious reason not to do it this way.
There was a problem hiding this comment.
Poked at this in fa00f9a. Thank you for the suggestion.
mikewest
force-pushed
the
framed-destination
branch
from
fa00f9a to
6c188fb
Compare
mikewest
changed the title
|
Updated this to include minimal |
|
Pinging this as well, as it should hopefully land alongside whatwg/fetch#948. |
annevk
approved these changes
Feb 11, 2020
|
It does seem like this needs rebasing first though. |
Currently, top-level and nested navigations set a request destination of "document" when performing the "process a navigate fetch" algorithm. This patch follows whatwg/fetch#948, splitting "document" into "frame" and "iframe" for nested navigation requests.
mikewest
force-pushed
the
framed-destination
branch
from
6c188fb to
50ce162
Compare
Rebased and force-pushed in 50ce162. WDYT? |
annevk
approved these changes
Feb 14, 2020
annevk
added
the
needs tests
|
Although I suppose this will reuse the tests from whatwg/fetch#948, right? |
I think that's correct, yes. |
annevk
added
do not merge yet
annevk
pushed a commit
to whatwg/fetch
that referenced
this pull request
Jun 5, 2020
As discussed in w3c/webappsec-fetch-metadata#45, this splits the "document" destination into "document", "frame", and "iframe". These destinations distinguish top-level navigation from nested navigation, and exposing this data via `Sec-Fetch-Dest` will allow developers to better understand the nature of a request. This patch also redefines "navigation request" and "non-subresource request" to include "embed" and "object" destinations as discussed at #948 (comment). That discussion also resulted in other changes: * whatwg/html#4976 * w3c/ServiceWorker#1486 Tests: * https://github.com/web-platform-tests/wpt/blob/master/fetch/metadata/embed.tentative.https.sub.html * https://github.com/web-platform-tests/wpt/blob/master/fetch/metadata/object.tentative.https.sub.html * https://github.com/web-platform-tests/wpt/blob/master/fetch/metadata/iframe.tentative.https.sub.html * https://github.com/web-platform-tests/wpt/blob/master/fetch/metadata/navigation.tentative.https.sub.html * https://github.com/web-platform-tests/wpt/blob/master/service-workers/service-worker/embed-and-object-are-not-intercepted.https.html
annevk
removed
the
do not merge yet
yutakahirano
pushed a commit
to whatwg/fetch
that referenced
this pull request
Jun 23, 2020
As discussed in w3c/webappsec-fetch-metadata#45, this splits the "document" destination into "document", "frame", and "iframe". These destinations distinguish top-level navigation from nested navigation, and exposing this data via `Sec-Fetch-Dest` will allow developers to better understand the nature of a request. This patch also redefines "navigation request" and "non-subresource request" to include "embed" and "object" destinations as discussed at #948 (comment). That discussion also resulted in other changes: * whatwg/html#4976 * w3c/ServiceWorker#1486 Tests: * https://github.com/web-platform-tests/wpt/blob/master/fetch/metadata/embed.tentative.https.sub.html * https://github.com/web-platform-tests/wpt/blob/master/fetch/metadata/object.tentative.https.sub.html * https://github.com/web-platform-tests/wpt/blob/master/fetch/metadata/iframe.tentative.https.sub.html * https://github.com/web-platform-tests/wpt/blob/master/fetch/metadata/navigation.tentative.https.sub.html * https://github.com/web-platform-tests/wpt/blob/master/service-workers/service-worker/embed-and-object-are-not-intercepted.https.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, top-level and nested navigations set a request destination of
"document" when performing the "process a navigate fetch" algorithm.
This patch follows whatwg/fetch#948, splitting "document" into "frame"
and "iframe" for nested navigation requests.
This patch aims to support the Fetch Metadata discussion in w3c/webappsec-fetch-metadata#45, and the Fetch patch in whatwg/fetch#948.
Sec-Fetch-Dest.documentvalue in https://github.com/web-platform-tests/wpt/tree/master/fetch/sec-metadata (note that this will be renamed to just "metadata" whenever Renaming fetch/metadata web platform tests web-platform-tests/wpt#19501 lands)./browsing-the-web.html ( diff )
/iframe-embed-object.html ( diff )