-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: make domintro typography more uniform #6901
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sideshowbarker
approved these changes
Jul 27, 2021
data-x="dom-CanvasRenderingContext2DSettings-willReadFrequently">willReadFrequently</code> | ||
member is true if the context is marked for <span | ||
data-x="concept-canvas-will-read-frequently">readback optimization</span>.</li> | ||
<li><code data-x="dom-CanvasRenderingContext2DSettings-willReadFrequently">willReadFrequently</code> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
<li><code data-x="dom-CanvasRenderingContext2DSettings-willReadFrequently">willReadFrequently</code> | |
<li>The <code data-x="dom-CanvasRenderingContext2DSettings-willReadFrequently">willReadFrequently</code> |
"Preparation" consists of uniformizing markup and fixing some bad tags so that an automated pass won't mess things up too much
Almost all wrapping changes.
If it's a single paragraph we don't wrap them
and convert inner <code>s into <span>s
They look especially weird with the code font
i.e. "( " -> "(") and " )" -> ")"
This was a bug in the previous script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements some of the changes described in whatwg/meta#190 (comment) for our "For web developers (non-normative)" boxes, i.e. "domintro" boxes. Although the first three domintros were rewritten by hand and thus reflect all of those changes, the rest were transformed in an automated fashion, with only the following transformations applied:
<code>
instead of just some property names.Additionally the nature of the automated process involved rewrapping all the
<dd>
contents, and unwrapping all<dt>
contents. Some linebreaks were removed and inserted as well to give a consistent style.Please remember to squash before merging!
I suggest reviewing the first commit and then optionally skimming some of the others at random.
/browsers.html ( diff )
/browsing-the-web.html ( diff )
/canvas.html ( diff )
/common-dom-interfaces.html ( diff )
/comms.html ( diff )
/custom-elements.html ( diff )
/dnd.html ( diff )
/dom.html ( diff )
/dynamic-markup-insertion.html ( diff )
/embedded-content-other.html ( diff )
/embedded-content.html ( diff )
/form-control-infrastructure.html ( diff )
/form-elements.html ( diff )
/forms.html ( diff )
/history.html ( diff )
/image-maps.html ( diff )
/imagebitmap-and-animations.html ( diff )
/input.html ( diff )
/interaction.html ( diff )
/interactive-elements.html ( diff )
/introduction.html ( diff )
/links.html ( diff )
/media.html ( diff )
/origin.html ( diff )
/scripting.html ( diff )
/semantics.html ( diff )
/server-sent-events.html ( diff )
/system-state.html ( diff )
/tables.html ( diff )
/text-level-semantics.html ( diff )
/timers-and-user-prompts.html ( diff )
/urls-and-fetching.html ( diff )
/web-messaging.html ( diff )
/web-sockets.html ( diff )
/webappapis.html ( diff )
/webstorage.html ( diff )
/window-object.html ( diff )
/workers.html ( diff )
/worklets.html ( diff )