Skip to content

Revert recent changes to rendering of <slot>, and some of the corresponding changes to its directionality and language #9880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Revert recent changes to rendering of <slot>, and some of the corresponding changes to its directionality and language #9880

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e75ecf
Revert recent changes to rendering of <slot>.
dbaron Oct 25, 2023
632d29e
Make corresponding changes to slot directionality.
dbaron Oct 26, 2023
a45814c
Make the corresponding change to language inheritance too.
dbaron Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13331,8 +13331,6 @@ Transport Protocol">HTTP&lt;/abbr> today.&lt;/p></code></pre> <!-- DO NOT REWRAP
<dd><p>Use the value of that attribute.</p></dd>

<dt>If the node's parent is a <span>shadow root</span></dt>
<dt>If the node is a <code>slot</code> element whose <span>root</span> is a <span>shadow
root</span></dt>
<dd><p>Use the <span>language</span> of that <span>shadow root</span>'s <span
data-x="concept-DocumentFragment-host">host</span>.</p></dd>

Expand Down Expand Up @@ -13685,7 +13683,8 @@ Transport Protocol">HTTP&lt;/abbr> today.&lt;/p></code></pre> <!-- DO NOT REWRAP

<li><p>If <var>descendant</var> is a <code>slot</code> element whose <span>root</span> is a
<span>shadow root</span>, then return the <span data-x="the
directionality">directionality</span> of <var>descendant</var>.</p></li>
directionality">directionality</span> of that <span>shadow root</span>'s <span
data-x="concept-DocumentFragment-host">host</span>.</p></li>

<li><p>If <var>descendant</var> is not a <code>Text</code> node, then
<span>continue</span>.</p></li>
Expand Down Expand Up @@ -13721,11 +13720,6 @@ Transport Protocol">HTTP&lt;/abbr> today.&lt;/p></code></pre> <!-- DO NOT REWRAP
<p>To compute the <dfn>parent directionality</dfn> given an element <var>element</var>:</p>

<ol>
<li><p>If <var>element</var> is a <code>slot</code> element whose <span>root</span> is a
<span>shadow root</span>, then return the <span data-x="the directionality">directionality</span>
of <var>element</var>'s <span>root</span>'s <span
data-x="concept-DocumentFragment-host">host</span>.</p></li>

<li><p>Let <var>parentNode</var> be <var>element</var>'s parent node.</p></li>

<li><p>If <var>parentNode</var> is a <span>shadow root</span>, then return the <span data-x="the
Expand Down Expand Up @@ -130240,16 +130234,15 @@ br[clear=all i], br[clear=both i] { clear: both; }</code></pre>

<pre><code class="css">@namespace "http://www.w3.org/1999/xhtml";

[dir]:dir(ltr), slot:dir(ltr), bdi:dir(ltr), input[type=tel i]:dir(ltr) { direction: ltr; }
[dir]:dir(rtl), slot:dir(rtl), bdi:dir(rtl) { direction: rtl; }
[dir]:dir(ltr), bdi:dir(ltr), input[type=tel i]:dir(ltr) { direction: ltr; }
[dir]:dir(rtl), bdi:dir(rtl) { direction: rtl; }

address, blockquote, center, div, figure, figcaption, footer, form, header, hr,
legend, listing, main, p, plaintext, pre, summary, xmp, article, aside, h1, h2,
h3, h4, h5, h6, hgroup, nav, section, search, table, caption, colgroup, col,
thead, tbody, tfoot, tr, td, th, dir, dd, dl, dt, menu, ol, ul, li, bdi, output,
slot, [dir=ltr i], [dir=rtl i], [dir=auto i] {
unicode-bidi: isolate; <!-- anything that's similar to display:block, plus
<bdi>, <output>, <slot>, and dir="" -->
[dir=ltr i], [dir=rtl i], [dir=auto i] {
unicode-bidi: isolate; <!-- anything that's similar to display:block, plus <bdi>, <output>, and dir="" -->
}

bdo, bdo[dir] { unicode-bidi: isolate-override; } <!-- bdo[dir] rule is to override the otherwise higher-specificity attribute selectors in the previous rule -->
Expand Down