-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make constructed stylesheets not support quirks mode #36
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nit, but @zcorpan is the final word.
@@ -240,6 +240,8 @@ above properties in its "Value" grammar. | |||
supported in the <code><a method for=CSS lt="supports(property, value)">supports()</a></code> static | |||
method of the {{CSS}} interface.</p> | |||
|
|||
<p><a>Quirky colors</a> must not be supported on a <a interface>CSSStyleSheet</a> where the <a>constructed flag</a> is set.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use {{CSSStyleSheet}}
instead, to get the proper monospace font. Here and below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cc @tabatkins to sanity-check
WPT would be good to have for this. What do you mean with link from a draft spec? |
OK, I'll try to make a WPT then.
For the "constructed flag" definition, which is currently only defined in https://wicg.github.io/construct-stylesheets/index.html#cssstylesheet-constructed-flag |
I appreciate that we're standardizing this, but I'd like the layering to be different I think. I think the model should be that a style sheet also has a quirks mode slot, which it typically inherits from a document, but not always. Note that you can also end up in this situation with the |
Yep, that's definitely the ideal layering, but I think given that the quirks mode spec already has several of these "this syntax must only be supported in X contexts", we should continue with that pattern for now, and let the editors of CSSOM/Quirks work on fixing the layering later. |
@rakina did you write a test for this? |
Constructed stylesheets should not support quirks mode. See WICG/construct-stylesheets#59. I'm not sure if I need to make a WPT for this and how to link from a draft spec. I guess this shouldn't be merged until constructable stylesheets are part of CSSOM?
cc @domenic
Preview | Diff