-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand introductory text and examples #187
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyroman
force-pushed
the
intro-examples
branch
from
September 13, 2023 09:57
f942b49
to
fc7ae45
Compare
Some simple introductory examples are added, along with some brief overview text of both URL patterns and (component-specific) pattern strings. Some more detailed examples already exist within the relevant parsing code. This contributes to resolving whatwg#127.
jeremyroman
force-pushed
the
intro-examples
branch
from
September 13, 2023 09:57
fc7ae45
to
37ef13b
Compare
sisidovski
reviewed
Sep 13, 2023
sisidovski
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w/ nits. Thank you!
jeremyroman
commented
Sep 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some simple introductory examples are added, along with some brief
overview text of both URL patterns and (component-specific) pattern
strings.
Some more detailed examples already exist within the relevant parsing
code.
This contributes to resolving #127.
Preview | Diff