basic stuff for single, and double left click mouse support #51
Conversation
… single and double click support
| void doubletap(uint32_t timestamp_ms, imu_quat_type quat, imu_euler_type velocities, bool ipc_enabled, | ||
| bool imu_calibrated, ipc_values_type *ipc_values) { | ||
| singletap(timestamp_ms, quat, velocities, ipc_enabled, imu_calibrated, ipc_values); | ||
| singletap(timestamp_ms, quat, velocities, ipc_enabled, imu_calibrated, ipc_values); |
There was a problem hiding this comment.
I think there should be a delay here? Just to make it seem a little more human in case some apps care. Like most OS's allow you to configure expectations around double-click.
| @@ -225,6 +225,19 @@ void deinit_outputs() { | |||
| evdev = NULL; | |||
| } | |||
| } | |||
| void singletap(uint32_t timestamp_ms, imu_quat_type quat, imu_euler_type velocities, bool ipc_enabled, | |||
| bool imu_calibrated, ipc_values_type *ipc_values) { | |||
| libevdev_uinput_write_event(uinput, EV_KEY, BTN_LEFT,1); | |||
There was a problem hiding this comment.
We should be doing something like the checks we have below, since a double-click only makes sense in these contexts (VR-Lite mouse mode specifically, should probably ignore for joystick mode):
if (uinput) {
if (is_joystick_mode(context.config)) {
...
} else if (is_mouse_mode(context.config)) {
| #define MT_RESET_CALIBRATION 3 | ||
| #define MT_SINGLE_CLICK 1 | ||
| #define MT_DOUBLE_CLICK 2 | ||
| #define MT_RECENTER_SCREEN 3 |
There was a problem hiding this comment.
Hmm... I think this is problematic, though I'm not sure the solution. I'd like to keep recenter/recalibrate at 2 and 3 taps, respectively, for a couple reasons: multi-tap is difficult to get right for some, so going beyond double-tap for something you may use a lot can add a bit of pain, and all my documentation, UI, and videos talk about double-tap for recenter.
The other issue I see with this is having something use single-tap. False-positives happen sometimes during head movements, so I feel hesitant adding something that triggers after just one tap.
| @@ -7,7 +7,7 @@ | |||
| #include <stdlib.h> | |||
| #include <stdio.h> | |||
|
|
|||
| #define MT_BUFFER_MS 25 | |||
| #define MT_BUFFER_MS 15 | |||
There was a problem hiding this comment.
I haven't played with these changes so I'm not sure if they make things better or worse, and this also tends to be a subjective experience, so the current settings work well for some but not others, etc... I would want to have this vetted through a decent sized group. Maybe it can go in a PR separate from this one if you meant to include it and think it's better than the current settings?
| bool imu_calibrated, ipc_values_type *ipc_values) { | ||
| singletap(timestamp_ms, quat, velocities, ipc_enabled, imu_calibrated, ipc_values); | ||
| singletap(timestamp_ms, quat, velocities, ipc_enabled, imu_calibrated, ipc_values); | ||
| } | ||
|
|
||
| void handle_imu_update(uint32_t timestamp_ms, imu_quat_type quat, imu_euler_type velocities, bool ipc_enabled, |
There was a problem hiding this comment.
If we move forward with this, I'm thinking we could actually just modify this signature with a param like int tapsDetected and then you'd be able to move the single/double tap stuff into the is_mouse_mode section that's already here.
|
Hey, let's get this closed out. I think we should either:
|
|
Closing |
This is a first go of basic left mouse support with the driver. By tapping on the side of the XReal Air, you can initiate a "tap" event. This was already existing in wheaney's code.
The updates with this PR move the following down in index and add a single left mouse click, and a double left mouse click:
Original:
#MT_RECENTER_SCREEN 2
#define MT_RESET_CALIBRATION 3
PR submission:
#define MT_SINGLE_CLICK 1
#define MT_DOUBLE_CLICK 2
#define MT_RECENTER_SCREEN 3
#define MT_RESET_CALIBRATION 4
There are additional changes to be made, and will come later, but this should help with basics.