Skip to content

Commit

Permalink
Handle not having the box and providing it via a box_url.
Browse files Browse the repository at this point in the history
The way this was implemented breaks with a terrible runtime error if you don't have the box
already installed nor a box_url in your vagrant file. However, this permits you to provide
the openstack api_key and auth_url directly in your box file. This wouldn't be possible if
you validated the config prior to handling the box url. The proper way to fix the terrible
runtime error would be to check for box_url directly in the HandleBoxUrl method in Vagrant
core.

Reviewed-by: Philippe Godin <[email protected]>

Conflicts:
	lib/vagrant-openstack-plugin/version.rb
  • Loading branch information
mat128 authored and Mathieu Mitchell committed Jun 12, 2013
1 parent 1dbf7ed commit 0835f2e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions lib/vagrant-openstack-plugin/action.rb
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ def self.action_ssh

def self.action_up
Vagrant::Action::Builder.new.tap do |b|
b.use HandleBoxUrl
b.use ConfigValidate
b.use Call, IsCreated do |env, b2|
if env[:result]
Expand Down

0 comments on commit 0835f2e

Please sign in to comment.