Merge remote-tracking branch 'thomasvs/master'

.gitignore

@@ -1,5 +1,4 @@
 *.pyc
-COPYING
 INSTALL
 Makefile
 Makefile.in

README.md

@@ -11,7 +11,7 @@ https://thomas.apestaart.org/thomas/trac/wiki/DAD/Rip).
 FEATURES
 --------
 * support for MusicBrainz for metadata lookup
-* support for AccurateRip verification
+* support for AccurateRip (V1) verification
 * detects sample read offset and ability to defeat cache of drives
 * performs test and copy rip
 * detects and rips Hidden Track One Audio
@@ -32,6 +32,7 @@ REQUIREMENTS
 - python-setuptools, for plugin support
 - python-cddb, for showing but not using disc info if not in musicbrainz
 - pycdio, for drive identification (optional)
+  - Required for drive offset and caching behaviour to be stored in the config file
 
 Additionally, if you're building from a git checkout:
 - autoconf
@@ -139,6 +140,11 @@ And attach the gzipped log file to your bug report.
 KNOWN ISSUES
 ------------
 - no GUI yet
+- only AccurateRip V1 CRCs are computed and checked against the online database
+- `rip offset find` fails to delete the temporary .wav files it creates if error occurs while ripping (thomasvs/morituri#75)
+- morituri detects the pre-emphasis flag in the TOC but doesn't add it to the cue sheet
+  - To improve the accuracy of the detection the sub-channel data should be scanned too
+- CD-Text is not used when ripping CDs not available in MusicBrainz DB
 
 GOALS
 -----

TODO

@@ -2,6 +2,8 @@ TODO:
 
 EASY
 
+- self.error() invokes exit() which is bad for a gui
+
 - change format to be %2d - %performer by default
   FIXME: why was this again?
 
@@ -12,6 +14,11 @@ EASY
 
 - add rip offset verify, to verify that the current offset looks coorect
 
+- handle not having wav plugin:
+  http://sprunge.us/DYjd
+  DEBUG [13888] "ChecksumTask 0xb5e8b290"        ChecksumTask      Jul 25 19:09:47      bus_error_cb: bus <gst.Bus object (bus2) at 0xb5e940a8>, message <gst.Message GstMessageError, gerror=(GError)NULL, debug=(string)"/var/tmp/portage/media-libs/gst-plugins-base-0.10.36-r1/work/gst-plugins-base-0.10.36/gst/playback/gstdecodebin.c\(1003\):\ close_pad_link\ \(\):\ /GstPipeline:pipeline0/GstDecodeBin:decode:\012No\ decoder\ to\ handle\ media\ type\ \'audio/x-wav\'"; from decode at 0x7f74fea8> (morituri/extern/task/gstreamer.py:211)
+DEBUG [13888] "ChecksumTask 0xb5e8b290"        ChecksumTask      Jul 25 19:09:47      set exception, 'exception GstException at /home/merlijn/archive/morituri/morituri/extern/task/gstreamer.py:217: bus_error_cb(): (<GError at 0x7f7f5360>, "/var/tmp/portage/media-libs/gst-plugins-base-0.10.36-r1/work/gst-plugins-base-0.10.36/gst/playback/gstdecodebin.c(1003): close_pad_link (): /GstPipeline:pipeline0/GstDecodeBin:decode:\\nNo decoder to handle media type \'audio/x-wav\'")' (morituri/extern/task/task.py:197)
+
 MEDIUM
 
 - after fixing relative, pregaps, and index 02, check when htoa is 0,

morituri/rip/drive.py

@@ -67,6 +67,7 @@ def do(self, args):
 
         info = drive.getDeviceInfo(self.options.device)
         if not info:
+            self.stdout.write('Drive caching behaviour not saved: could not get device info (requires pycdio).\n')
             return
 
         self.stdout.write(

morituri/rip/offset.py

@@ -239,6 +239,7 @@ def _foundOffset(self, device, offset):
 
         info = drive.getDeviceInfo(device)
         if not info:
+            self.stdout.write('Offset not saved: could not get device info (requires pycdio).\n')
             return
 
         self.stdout.write('Adding read offset to configuration file.\n')