Link secondary devices as primary device #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The above mentioned issue seems to be due to PNI fields not being set from the primary-device side here. So I guess this MR is blocked by whisperfish/libsignal-service-rs#206. |
Schmiddiii
force-pushed
the
link-secondary-as-primary
branch
2 times, most recently
from
0a33e4e
to
7fb2d40
Compare
Schmiddiii
force-pushed
the
link-secondary-as-primary
branch
2 times, most recently
from
9019a2a
to
18d83a6
Compare
Schmiddiii
force-pushed
the
link-secondary-as-primary
branch
2 times, most recently
from
eed6c9c
to
af72b47
Compare
Schmiddiii
force-pushed
the
link-secondary-as-primary
branch
2 times, most recently
from
668bb1f
to
75b0ae3
Compare
Schmiddiii
force-pushed
the
link-secondary-as-primary
branch
3 times, most recently
from
6c11f55
to
83dbac0
Compare
Schmiddiii
force-pushed
the
link-secondary-as-primary
branch
3 times, most recently
from
41a43c5
to
e74ea1b
Compare
Schmiddiii
force-pushed
the
link-secondary-as-primary
branch
2 times, most recently
from
e4b913d
to
2a3bd59
Compare
Schmiddiii
force-pushed
the
link-secondary-as-primary
branch
from
2a3bd59
to
7501122
Compare
Schmiddiii
force-pushed
the
link-secondary-as-primary
branch
from
7501122
to
03ffb34
Compare
Schmiddiii
force-pushed
the
link-secondary-as-primary
branch
from
03ffb34
to
8e9c62b
Compare
Schmiddiii
force-pushed
the
link-secondary-as-primary
branch
2 times, most recently
from
0c30605
to
de9c6d0
Compare
Schmiddiii
force-pushed
the
link-secondary-as-primary
branch
from
de9c6d0
to
a1dda1c
Compare
|
After #245 was merged, this is now finally workind and ready for review. |
|
Note that as mentioned in the WF chat, something is wrong with the device name querying the linked devices. It is some base64-encoded string. I don't know how to solve that yet. |
|
If it is anything like it used to be for secondary linking, the device name was (at least at some point) encrypted. |
|
Yes, something similar was mentioned in the chat. I may need to investigate this closer before this can be merged. |
Schmiddiii
force-pushed
the
link-secondary-as-primary
branch
from
01d0e5c
to
2584867
Compare
|
After whisperfish/libsignal-service-rs#300, it should now be ready. |
Schmiddiii
force-pushed
the
link-secondary-as-primary
branch
from
2584867
to
1794c01
Compare
|
Great addition, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently does not work due to an issue on the secondary-side:
The code was mostly copied from what Whisperfish is doing.
Depends on whisperfish/libsignal-service-rs#250