Bump dependencies for when still running on ruby 2.7 (#480)

* Bump cucumber, minitest, mocha, parser, rake, reek, rubocop, and ruby_parser dependencies Also address Lint/UselessAssignment and Style/MapIntoArray warnings that newer versions of rubocop will complain about on newer versions of Ruby. * Update rubycritic.gemspec --------- Co-authored-by: Nuno Silva <[email protected]>
whitesmith · Apr 14, 2024 · e62770b · e62770b
1 parent 9b8cddf
commit e62770b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 13 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,6 @@
 # main [(unreleased)](https://github.com/whitesmith/rubycritic/compare/v4.9.0...main)
 
+* [CHANGE] Bump cucumber, minitest, parser, rake, reek, rubocop, and ruby_parser dependencies (by [@faisal][])
 * [CHANGE] Fix some typos (by [@jbampton][])
 * [FEATURE] Add coverage_path configuration option (by [@exoego][])
 

diff --git a/lib/rubycritic/analysers/coverage.rb b/lib/rubycritic/analysers/coverage.rb
@@ -115,11 +115,7 @@ def results
         if Gem.loaded_specs['simplecov'].version >= Gem::Version.new('0.19')
           ::SimpleCov::Result.from_hash(resultset)
         else
-          array = []
-          resultset.each do |command_name, data|
-            array << ::SimpleCov::Result.from_hash(command_name => data)
-          end
-          array
+          resultset.map { |command_name, data| ::SimpleCov::Result.from_hash(command_name => data) }
         end
       end
     end

diff --git a/rubycritic.gemspec b/rubycritic.gemspec
@@ -33,11 +33,11 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'flay', '~> 2.13'
   spec.add_runtime_dependency 'flog', '~> 4.7'
   spec.add_runtime_dependency 'launchy', '>= 2.5.2'
-  spec.add_runtime_dependency 'parser', '>= 3.2.2.1'
+  spec.add_runtime_dependency 'parser', '>= 3.2.2.4'
   spec.add_runtime_dependency 'rainbow', '~> 3.1.1'
-  spec.add_runtime_dependency 'reek', '~> 6.0', '< 7.0'
+  spec.add_runtime_dependency 'reek', '~> 6.0', '< 6.2'
   spec.add_runtime_dependency 'rexml'
-  spec.add_runtime_dependency 'ruby_parser', '~> 3.20'
+  spec.add_runtime_dependency 'ruby_parser', '~> 3.21'
   spec.add_runtime_dependency 'simplecov', '>= 0.22.0'
   spec.add_runtime_dependency 'tty-which', '~> 0.5.0'
   spec.add_runtime_dependency 'virtus', '~> 2.0'
@@ -49,16 +49,16 @@ Gem::Specification.new do |spec|
   else
     spec.add_development_dependency 'byebug', '~> 11.0', '>= 10.0'
   end
-  spec.add_development_dependency 'cucumber', '~> 9.0.2', '!= 9.0.0'
+  spec.add_development_dependency 'cucumber', '~> 9.2.0', '!= 9.0.0'
   spec.add_development_dependency 'diff-lcs', '~> 1.3'
   spec.add_development_dependency 'fakefs', '~> 2.5.0'
   spec.add_development_dependency 'mdl', '~> 0.13.0', '>= 0.12.0'
-  spec.add_development_dependency 'minitest', '~> 5.20.0', '>= 5.3.0'
+  spec.add_development_dependency 'minitest', '~> 5.22.2', '>= 5.3.0'
   spec.add_development_dependency 'minitest-around', '~> 0.5.0', '>= 0.4.0'
-  spec.add_development_dependency 'mocha', '~> 2.1.0'
-  spec.add_development_dependency 'rake', '~> 13.0.6', '>= 11.0.0'
+  spec.add_development_dependency 'mocha', '~> 2.2.0'
+  spec.add_development_dependency 'rake', '~> 13.2.0', '>= 11.0.0'
   spec.add_development_dependency 'rexml', '>= 3.2.0'
-  spec.add_development_dependency 'rubocop', '~> 1.57.1', '>= 1.54.0'
+  spec.add_development_dependency 'rubocop', '~> 1.59.0', '>= 1.54.0' # >= 1.60 requires Ruby 3
   spec.add_development_dependency 'rubocop-minitest'
   spec.add_development_dependency 'rubocop-performance'
   spec.add_development_dependency 'rubocop-rake'