Add Support for Google Cloud Artifact Registry #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvanderen1
changed the title
whoan
reviewed
Jun 6, 2024
| @@ -300,6 +307,11 @@ init_variables() { | |||
|
|
|||
| # split tags (to allow multiple comma-separated tags) | |||
| IFS=, read -ra INPUT_IMAGE_TAG <<< "$INPUT_IMAGE_TAG" | |||
|
|
|||
There was a problem hiding this comment.
I'd rather move this condition as an elif insode _set_namespace (after the elif of _is_gcloud_container_registry.
Let me know if you want me to do it if it's not clear.
Thanks for the contribution!
There was a problem hiding this comment.
I appreciate it man!
I was not sure if it would be confusing to call _set_namespace just to keep $NAMESPACE empty for _is_gcloud_artifact_registry. However, I can move this condition 👍🏻 .
Also, this PR is not quite ready yet. The error I had seen via #158 makes me believe I may had done something incorrect since this error is thrown in entrypoint.sh#L29-L32. I have not had a chance to test this PR yet, but I'll try to get to it at some point 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #158
Description
This adds the ability to specify a Google Cloud Artifact Registry repository and image with this action. Specifically:
image_digestas a potential input. Instead ofimage_name:image_tag, you can specifyimage_name@image_digest.