Add Ed (edwards curve), EdDSA (Ed25519/Ed448) and XDH (X25519/X448) interfaces #61
Conversation
…and XDH (X25519/X448) interfaces
There was a problem hiding this comment.
Thanks for the PR!
This would be a lovely addition to the library!
While I'm investigating a bit regarding the naming for the algorithms and curves, could you try to implement those algorithms in openssl and webcrypto providers?
As far as I see, web crypto recently added support for them (f.e. in deriveBits), so it's better to recheck if it's supported in latest browsers/nodejs
As for openssl - I'm pretty sure it's supported for some time
| @@ -0,0 +1,107 @@ | |||
| package algorithms | |||
There was a problem hiding this comment.
wrong package name, should be prefixed with dev.whyoleg.cryptography.providers.jdk.
Probably an IDE glitch :)
| @@ -0,0 +1,76 @@ | |||
| package dev.whyoleg.cryptography.algorithm | |||
There was a problem hiding this comment.
should be dev.whyoleg.cryptography.algorithms (with s at the end)
| @@ -0,0 +1,26 @@ | |||
| package algorithms | |||
There was a problem hiding this comment.
should be dev.whyoleg.cryptography.algorithms
| @@ -0,0 +1,26 @@ | |||
| package algorithms | |||
|
|
|||
| import dev.whyoleg.cryptography.CryptographyAlgorithmId | |||
There was a problem hiding this comment.
minor: star-imports are preferred and should be enforced by a config in .idea, looks like it doesn't work all the time
(same for other new files)
| @@ -0,0 +1,25 @@ | |||
| package algorithms | |||
There was a problem hiding this comment.
should be dev.whyoleg.cryptography.algorithms
| @@ -0,0 +1,39 @@ | |||
| package algorithms | |||
There was a problem hiding this comment.
should be dev.whyoleg.cryptography.providers.jdk.algorithms
| @@ -0,0 +1,43 @@ | |||
| package algorithms | |||
There was a problem hiding this comment.
should be dev.whyoleg.cryptography.providers.jdk.algorithms
#60 is already included in this branch.