#1007 Do not bind session as a side effect when removing pages (#1008)

--------- Co-authored-by: Martin Grigorov <[email protected]> Co-authored-by: Maxim Solodovnik <[email protected]>
wicketstuff · Aug 22, 2024 · 1d780e9 · 1d780e9
1 parent cc03efd
commit 1d780e9
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 9 deletions.
diff --git a/...common/src/main/java/org/wicketstuff/datastores/common/SessionQuotaManagingDataStore.java b/...common/src/main/java/org/wicketstuff/datastores/common/SessionQuotaManagingDataStore.java
@@ -66,14 +66,7 @@ public SessionQuotaManagingDataStore(IPageStore delegate, Bytes maxBytes)
 
 	private SessionData getSessionData(IPageContext context, boolean create)
 	{
-		return context.getSessionData(KEY, () -> {
-			if (create)
-			{
-				return dataCreator.get();
-			}
-
-			return null;
-		});
+		return context.getSessionData(KEY, create ? dataCreator : null);
 	}
 
 	@Override

diff --git a/...ts/src/main/java/org/wicketstuff/datastores/common/SessionQuotaManagingDataStoreTest.java b/...ts/src/main/java/org/wicketstuff/datastores/common/SessionQuotaManagingDataStoreTest.java
@@ -1,10 +1,13 @@
 package org.wicketstuff.datastores.common;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.never;
 import static org.mockito.Mockito.verify;
 
+import org.apache.wicket.MetaDataKey;
 import org.apache.wicket.mock.MockPageContext;
 import org.apache.wicket.mock.MockPageStore;
 import org.apache.wicket.pageStore.IPageContext;
@@ -97,7 +100,19 @@ public void removePage() {
 	}
 
 	@Test
-	void addPageDoesNotRemovePageFromDelegate() {
+	public void removePageShouldNotSupplyDefaultValueWhenGettingSessionData() {
+		MockPageStore delegate = new MockPageStore();
+
+		IPageContext context = mock(IPageContext.class);
+
+		IPageStore quotaStore = new SessionQuotaManagingDataStore(delegate, Bytes.bytes(page1.getData().length + page3.getData().length));
+		quotaStore.removePage(context, page1);
+
+		verify(context).getSessionData(any(MetaDataKey.class), eq(null));
+	}
+
+	@Test
+ 	void addPageDoesNotRemovePageFromDelegate() {
 		IPageStore delegate = mock(IPageStore.class);
 
 		IPageContext context = new MockPageContext();