Fix warnings

wiechula · Jan 16, 2024 · 5a44644 · 5a44644
1 parent 2af2d97
commit 5a44644
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/DataFormats/Detectors/TPC/include/DataFormatsTPC/IDC.h b/DataFormats/Detectors/TPC/include/DataFormatsTPC/IDC.h
@@ -85,7 +85,6 @@ struct Data {
 
   uint32_t getLinkValue(const uint32_t link) const
   {
-    const auto valPtr = dataWords;
     const uint32_t offset = link * IDCvalueBits;
     const uint32_t selectedWord = offset / 8;
     const uint32_t requiredShift = offset % 8;

diff --git a/DataFormats/Detectors/TPC/include/DataFormatsTPC/LaserTrack.h b/DataFormats/Detectors/TPC/include/DataFormatsTPC/LaserTrack.h
@@ -36,7 +36,7 @@ class LaserTrack : public o2::track::TrackPar
   static constexpr std::array<float, 4> CoarseBundleZPos{243.5, 165.5, 82, 11.5};              ///< coarse z-position of the laser bundles
 
   LaserTrack() = default;
-  LaserTrack(int id, float x, float alpha, const std::array<float, o2::track::kNParams>& par) : mID(id), o2::track::TrackPar(x, alpha, par) { ; }
+  LaserTrack(int id, float x, float alpha, const std::array<float, o2::track::kNParams>& par) : o2::track::TrackPar(x, alpha, par), mID(id) {}
   LaserTrack(LaserTrack const&) = default;
 
   /// set laser track ID

diff --git a/DataFormats/Detectors/TPC/src/ClusterNativeHelper.cxx b/DataFormats/Detectors/TPC/src/ClusterNativeHelper.cxx
@@ -63,7 +63,7 @@ std::unique_ptr<ClusterNativeAccess> ClusterNativeHelper::createClusterNativeInd
 {
   std::unique_ptr<ClusterNativeAccess> retVal(new ClusterNativeAccess);
   memset(retVal.get(), 0, sizeof(*retVal));
-  for (int i = 0; i < clusters.size(); i++) {
+  for (size_t i = 0; i < clusters.size(); i++) {
     if (retVal->nClusters[clusters[i].sector][clusters[i].globalPadRow]) {
       LOG(error) << "Received two containers for the same sector / row";
       return std::unique_ptr<ClusterNativeAccess>();
@@ -77,7 +77,7 @@ std::unique_ptr<ClusterNativeAccess> ClusterNativeHelper::createClusterNativeInd
   }
   retVal->clustersLinear = buffer.get();
   retVal->setOffsetPtrs();
-  for (int i = 0; i < clusters.size(); i++) {
+  for (size_t i = 0; i < clusters.size(); i++) {
     memcpy(&buffer[retVal->clusterOffset[clusters[i].sector][clusters[i].globalPadRow]], clusters[i].clusters.data(), sizeof(*retVal->clustersLinear) * clusters[i].clusters.size());
     if (mcTruth) {
       for (unsigned int j = 0; j < clusters[i].clusters.size(); j++) {
@@ -87,7 +87,7 @@ std::unique_ptr<ClusterNativeAccess> ClusterNativeHelper::createClusterNativeInd
       }
     }
   }
-  return (std::move(retVal));
+  return retVal;
 }
 
 ClusterNativeHelper::Reader::~Reader()

diff --git a/Detectors/TPC/calibration/include/TPCCalibration/LaserTracksCalibrator.h b/Detectors/TPC/calibration/include/TPCCalibration/LaserTracksCalibrator.h
@@ -24,7 +24,7 @@
 namespace o2::tpc
 {
 
-class LaserTracksCalibrator : public o2::calibration::TimeSlotCalibration<CalibLaserTracks>
+class LaserTracksCalibrator final : public o2::calibration::TimeSlotCalibration<CalibLaserTracks>
 {
   using TFType = o2::calibration::TFType;
   using Slot = o2::calibration::TimeSlot<o2::tpc::CalibLaserTracks>;