✅ fix: apply http header error

wifievent · Dec 17, 2021 · 7375c26 · 7375c26
1 parent c25891c
commit 7375c26
Show file tree

Hide file tree

Showing 5 changed files with 40 additions and 11 deletions.
diff --git a/app/captiveportal/captiveportal.pro b/app/captiveportal/captiveportal.pro
@@ -1,6 +1,6 @@
 QT -= gui
 
-CONFIG += c++17
+CONFIG += c++2a
 TEMPLATE = app
 CONFIG += qt
 

diff --git a/app/captiveportal/weuiserver.cpp b/app/captiveportal/weuiserver.cpp
@@ -34,6 +34,20 @@ void WEUIServer::setHttpResponse() {
     int size = 0;
     DLOG(INFO) << "request path:" << path;
 
+    if(path.ends_with(".css")) {
+        uiresponse_.setHTTPHeader("Content-Type", "text/css;charset=UTF-8");
+    }
+    else if(path.ends_with(".js")) {
+        uiresponse_.setHTTPHeader("Content-Type", "text/javascript;charset=UTF-8");
+    }
+    else {
+        uiresponse_.setHTTPHeader("Content-Type", "text/html");
+    }
+
+    if(denyDotDotPacket(path)) {
+        return;
+    }
+
     if(path == "/") {
         size = getWebUIData("/index.html");
         uiresponse_.setResponseBody(ui_);
@@ -105,3 +119,17 @@ std::string WEUIServer::getDateTime() {
     return dateheader;
 }
 
+bool WEUIServer::denyDotDotPacket(std::string path)
+{
+    if(path.find("..") != std::string::npos) {
+        DLOG(INFO) << "there is .. string from path:" << path;
+        uiresponse_.setProtocol(HTTP1_1);
+        uiresponse_.setStatusCode(403);
+        uiresponse_.setReasonPhrase();
+        uiresponse_.setHTTPHeader("Date", getDateTime());
+        uiresponse_.setHTTPHeader("Server", "UIServer");
+        uiresponse_.makeResponse();
+        return true;
+    }
+    return false;
+}
diff --git a/app/captiveportal/weuiserver.h b/app/captiveportal/weuiserver.h
@@ -28,4 +28,5 @@ class WEUIServer : public TcpServer
     void setHttpResponse();
     int getWebUIData(std::string path);
     std::string getDateTime();
+    bool denyDotDotPacket(std::string path);
 };
diff --git a/app/uiserver-test/uiserver-test.pro b/app/uiserver-test/uiserver-test.pro
@@ -1,6 +1,6 @@
 QT -= gui
 
-CONFIG += c++20
+CONFIG += c++2a
 TEMPLATE = app
 CONFIG += qt
 

diff --git a/app/uiserver-test/uiserver.cpp b/app/uiserver-test/uiserver.cpp
@@ -29,15 +29,15 @@ void UIServer::setHttpResponse() {
     int size = 0;
     DLOG(INFO) << "request path:" << path;
 
-//    if(path.ends_with(".css")) {
-//        uiresponse_.setHTTPHeader("Content-Type", "text/css;charset=UTF-8");
-//    }
-//    else if(path.ends_with(".js")) {
-//        uiresponse_.setHTTPHeader("Content-Type", "text/javascript;charset=UTF-8");
-//    }
-//    else {
-//        uiresponse_.setHTTPHeader("Content-Type", "text/html");
-//    }
+    if(path.ends_with(".css")) {
+        uiresponse_.setHTTPHeader("Content-Type", "text/css;charset=UTF-8");
+    }
+    else if(path.ends_with(".js")) {
+        uiresponse_.setHTTPHeader("Content-Type", "text/javascript;charset=UTF-8");
+    }
+    else {
+        uiresponse_.setHTTPHeader("Content-Type", "text/html");
+    }
 
     if(denyDotDotPacket(path)) {
         return;