[FIX] speculative fixes for performance on Android 14+ #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n Android 14 (redux)
rksh
commented
Jan 10, 2025
| @@ -302,7 +302,7 @@ | |||
| <service | |||
| android:name=".WigleService" | |||
| android:enabled="true" | |||
| android:foregroundServiceType="location" | |||
| android:foregroundServiceType="location|dataSync" | |||
There was a problem hiding this comment.
adding data sync to properties of background service thread, since database writes are a file operation
rksh
commented
Jan 10, 2025
| Logging.info("service startForeground version R+"); | ||
| startForeground(NOTIFICATION_ID, notification, | ||
| ServiceInfo.FOREGROUND_SERVICE_TYPE_LOCATION | ServiceInfo.FOREGROUND_SERVICE_TYPE_DATA_SYNC); | ||
| } else { |
There was a problem hiding this comment.
special case to fix priority for startForeground for Android R+
rksh
commented
Jan 10, 2025
| private static final int MAX_QUEUE = 512; | ||
| private static final int MAX_DRAIN = 512; // seems to work fine slurping the whole darn thing | ||
| private static final int MAX_QUEUE = Build.VERSION_CODES.R >= Build.VERSION.SDK_INT ? 768 : 512; | ||
| private static final int MAX_DRAIN = MAX_QUEUE; |
There was a problem hiding this comment.
leaving more queue depth in R+
rksh
commented
Jan 10, 2025
| @@ -282,7 +282,7 @@ else if ( newOK && NETWORK_PROVIDER.equals( newLocation.getProvider() ) ) { | |||
| } else if (prevLocation == null || prevLocation.getTime() < currentLocation.getTime()) { | |||
| // initialize previous location | |||
| prevLocation = currentLocation; | |||
| } else if (prevLocation != null){ | |||
| } else if (prevLocation != null) { | |||
| if (currentLocation.getTime() != prevLocation.getTime()) { | |||
There was a problem hiding this comment.
log message improvement
uhtu
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code changes attempting to get background scanning working properly in Android 14 (redux)
not yet working