Improve code using serializable extensions #4196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isira-Seneviratne
requested review from
cooltey,
dbrant and
sharvaniharan
as code owners
Isira-Seneviratne
force-pushed
the
Serializable_extensions
branch
from
8f1c21e to
3347a7b
Compare
Isira-Seneviratne
force-pushed
the
Serializable_extensions
branch
from
506ce42 to
eddd892
Compare
Isira-Seneviratne
force-pushed
the
Serializable_extensions
branch
from
60b1249 to
5902d11
Compare
Isira-Seneviratne
changed the title
|
This PR can be merged only if it is slimmed down to only add the serializable extensions, and nothing else. (No moving of constants, no changes to how we pass arguments to fragments, no changes to navigation tab switching.) |
Isira-Seneviratne
force-pushed
the
Serializable_extensions
branch
from
3cd8773 to
28ebbd9
Compare
# Conflicts: # app/src/main/java/org/wikipedia/search/SearchFragment.kt
# Conflicts: # app/src/main/java/org/wikipedia/descriptions/DescriptionEditActivity.kt # app/src/main/java/org/wikipedia/descriptions/DescriptionEditFragment.kt # app/src/main/java/org/wikipedia/edit/EditSectionActivity.kt
# Conflicts: # app/src/main/java/org/wikipedia/commons/ImagePreviewViewModel.kt # app/src/main/java/org/wikipedia/diff/ArticleEditDetailsViewModel.kt # app/src/main/java/org/wikipedia/edit/insertmedia/InsertMediaViewModel.kt # app/src/main/java/org/wikipedia/edit/templates/TemplatesSearchViewModel.kt # app/src/main/java/org/wikipedia/feed/onthisday/OnThisDayViewModel.kt # app/src/main/java/org/wikipedia/suggestededits/SuggestedEditsCardsViewModel.kt # app/src/main/java/org/wikipedia/watchlist/WatchlistExpiryDialogViewModel.kt
# Conflicts: # app/src/main/java/org/wikipedia/search/SearchFragment.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new serializable retrieval methods in
IntentCompatandBundleCompatto fix the deprecation warnings.