Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to clear locally stored donation history #5196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cesonha
Copy link

@cesonha cesonha commented Dec 29, 2024

Please Read, this is a WIP

This is my first open source contribution and this PR is still a work in progress, I hope you can help me understand how can I put the translation and if this class is easily testable, but I will take my time to see how can i write some automated tests for it.

What does this do?

This will add a new preference in the SettingsFragment that enables the user to delete the local donation history. All this done respecting the business rules defined in the Phabricator ticket. The new preference only shows if the donation history is not empty and after the user deletes it the preference hides.

Why is this needed?

Please refer to the Phabricator's link Background section
Phabricator:
https://phabricator.wikimedia.org/T380662

Screenshot

image

@cesonha
Copy link
Author

cesonha commented Dec 29, 2024

Hi everyone, this is my first contribution and I have some doubts that I would be happy to get some clarification:

  • I saw that the iOS and Android Settings screen have a different UI and the preferences are organized in different sections, how can I know that the way I did is approved by the UX/UI team?
  • What should I do regarding the translation/localization, do I need to do it by myself?
  • What about unit tests, I understand that some classes might be easier to test than others, is there a discussion for that? I want to add tests to my PR but some guidance would be nice!
  • Do we need a summary for this preference?

@cesonha cesonha force-pushed the T380662 branch 2 times, most recently from a3b768a to 36061be Compare December 29, 2024 03:22
@cesonha cesonha changed the title [WIP] Feat: T380662 Allow users to clear locally stored donation history Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant