Compose About Activity conversion #5246
Conversation
- adds HtmlText component - adds preference for testing
- adds proper html string - adds body and footer for the about Activity - updates Snackbar, HtmlText - fixes app theme issue, - ui fixes
Williamrai
added
HOLD
Williamrai
added
WIP
- code fixes - converts LicenseActivity to Compose
Williamrai
added
Ready to merge
# Conflicts: # app/src/main/AndroidManifest.xml
| ), | ||
| linkInteractionListener = { | ||
| if (linkTextData.asset != null) { | ||
| println("orange: content ${linkTextData.text}") |
There was a problem hiding this comment.
Please remove test related println() code.
| }, | ||
| topBar = { | ||
| WikiTopAppBar( | ||
| title = "About", |
There was a problem hiding this comment.
Please use the string reference.
| ) | ||
| }, | ||
| topBar = { | ||
| WikiTopAppBar( |
There was a problem hiding this comment.
Something I have noticed is that it does not show the tooltip for the back button. Would it be possible to update the WikiTopAppBar for the back button (home button) for its content description for accessibility?
| } | ||
|
|
||
| @Composable | ||
| fun AboutScreenContent( |
There was a problem hiding this comment.
I like the way you separate the layout into different sections!
| }, | ||
| ), | ||
| painter = painterResource(R.drawable.w_nav_mark), | ||
| contentDescription = null, |
There was a problem hiding this comment.
Since this is a clickable icon, to improve accessibility, consider adding a new string for the content description of the globe logo.
| private lateinit var binding: ActivityAboutBinding | ||
| @Composable | ||
| fun AboutWikipediaScreen( | ||
| modifier: Modifier = Modifier, |
There was a problem hiding this comment.
It looks like an unused parameter, can we remove it?
|
|
||
| @Preview | ||
| @Composable | ||
| private fun AboutWikipediaImagePreview() { |
There was a problem hiding this comment.
Not sure but do we need to keep this one?
| binding = ActivityLicenseBinding.inflate(layoutInflater) | ||
| setContentView(binding.root) | ||
| setNavigationBarColor(getThemedColor(this, android.R.attr.windowBackground)) | ||
| val asset = intent.getStringExtra(ASSET) ?: "" |
There was a problem hiding this comment.
It is fine to use the "asset" string here.
What does this do?
Converts About Activity to Compose
Phabricator:
https://phabricator.wikimedia.org/T384362
This also resolves the license screen issue.
https://phabricator.wikimedia.org/T384526