Namespaced all CSS classes #229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like you were not aware of #105. It contains explanation why the grid classes cannot be renamed in this way. Basically the only way is to migrate Translate etc. to something else first. |
|
I did a little research on flexbox as replacement for uls grid. It seems flexbox is not recommended as drop-in grid replacement. One thing we could do is to copy uls grid to translate with prefixing the classes. This leads to some (but not very much) CSS duplication and breaks the dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates every CSS class the plug-in uses to be namespaced with "uls-". This was most problematic with the grid classes, which are very likely to conflict with a project's established grid system.