Skip to content

Commit

Permalink
tests: install fake_useragent != 2.0 for Python 3.8
Browse files Browse the repository at this point in the history
Bug: T381715
Change-Id: I5da177c5a1d2f7f09fa4ea7c45d6266c6b74a839
  • Loading branch information
xqt committed Dec 7, 2024
1 parent ca5cd51 commit 0e26b5d
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
1 change: 0 additions & 1 deletion .github/workflows/pywikibot-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ jobs:
if [ -f dev-requirements.txt ]; then pip install -r dev-requirements.txt; fi
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
pip install wikitextparser
pip install "fake_useragent != 2.0; python_version=='3.8'"
- name: Install setuptools
if: ${{ (matrix.python-version >= '3.12') || (matrix.os == 'macOS-latest') }}
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/sysop_write_tests-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ jobs:
pip --version
if [ -f dev-requirements.txt ]; then pip install -r dev-requirements.txt; fi
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
pip install "fake_useragent != 2.0; python_version=='3.8'"
- name: Generate user files
run: |
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/windows_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ jobs:
pip install -r dev-requirements.txt
pip install -r requirements.txt
pip install wikitextparser
pip install "fake_useragent != 2.0; python_version=='3.8'"
- name: Generate user files
run: |
Expand Down
5 changes: 4 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,10 @@
'mwoauth!=0.3.1,>=0.2.4',
],
'html': ['beautifulsoup4>=4.7.1'],
'http': ['fake-useragent>=1.4.0'],
'http': [
'fake-useragent>=1.4.0; python_version > "3.8"',
'fake-useragent>=1.4.0, < 2.0.0; python_version < "3.9"', # T381715
],
}


Expand Down

0 comments on commit 0e26b5d

Please sign in to comment.